Skip to content

fix: Wireless cyclic index remains unchanged #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 23, 2025
+1 −0
Merged

fix: Wireless cyclic index remains unchanged #4083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/application/flow/step_node/loop_node/impl/base_loop_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ def generate_while_loop(current_index: int):
index = current_index
while True:
yield index, index
index += 1


def loop(workflow_manage_new_instance, node: INode, generate_loop):
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generate_while_loop function is working correctly as it generates an infinite sequence of tuples starting from the given current_index. However, there are a couple of minor improvements and suggestions:

  1. Variable Naming: The variable name 'index' is used twice within the function without distinction in their meanings. Consider renaming one of them to avoid confusion.

  2. Docstring: It’s good practice to include a docstring at the top of functions that explain what they do, their parameters, return value, and if applicable, any assumptions or caveats with the implementation.

Here's the modified code with these suggestions:

@@ -115,8 +115,9 @@ def generate_whiled_loop(current_index: int):
     # Use the first 'index' for clarity
     start_index = current_index

     # Generate an infinite loop
     while True:
         yield start_index, start_index
         start_index += 1


def loop(workflow_manage_new_instance, node: INode, generate_while_loop):

Updated Docstrings (if needed):

For example,

def generate_while_loop(current_index: int) -> Iterable[Tuple[int, int]]:
    """Generate an infinite sequence of (index, index) pairs starting from the current index."""
    start_index = current_index

    while True:
        yield start_index, start_index
        start_index += 1


def loop(
    workflow_manage_new_instance: WorkflowManageNewInstance,
    node: INode,
    generate_while_loop: Callable[[int], Iterable[Tuple[int, int]]],
) -> None:
    """Loop through nodes using the provided generator function."""
    # Implement logic using the generated while-loop iterator
    pass

These changes enhance the readability and maintainability of your code.

Expand Down
Loading