Skip to content

fix: Infinite loop increases maximum loop count limit #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 23, 2025
Merged

fix: Infinite loop increases maximum loop count limit #4089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/flow/step_node/loop_node/impl/base_loop_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from maxkb.const import CONFIG
from django.utils.translation import gettext as _

max_loop_count = (CONFIG.get("MAX_LOOP_COUNT") or 1000)
max_loop_count = int((CONFIG.get("MAX_LOOP_COUNT") or 1000))


def _is_interrupt_exec(node, node_variable: Dict, workflow_variable: Dict):
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your function _is_interrupt_exec has a few minor improvements:

  1. Consistent Type Hinting: You added from collections import Dict, but since Python supports type hints natively with dictionaries like Dict[key_type, value_type], you can remove this line.

  2. Conversion to Integer: The conversion of CONFIG.get("MAX_LOOP_COUNT") to an integer is already done using (int()). This seems redundant and can be removed if the default value (1000) is also converted to an integer implicitly in Python.

Here's the revised code:

from maxkb.const import CONFIG
from django.utils.translation import gettext as _

max_loop_count = int(CONFIG.get("MAX_LOOP_COUNT", 1000))


def _is_interrupt_exec(node, node_variable: dict, workflow_variable: dict):

These changes improve readability slightly without introducing unnecessary complexity.

Expand Down
Loading