Skip to content

style: Highly optimized when adding BREAK and Continue nodes #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 24, 2025
Merged

style: Highly optimized when adding BREAK and Continue nodes #4102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/workflow/common/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ export const loopContinueNode = {
type: WorkflowType.LoopContinueNode,
text: t('views.applicationWorkflow.nodes.loopContinueNode.text'),
label: t('views.applicationWorkflow.nodes.loopContinueNode.label'),
height: 600,
height: 100,
properties: {
width: 600,
stepName: t('views.applicationWorkflow.nodes.loopContinueNode.label'),
Expand Down Expand Up @@ -510,7 +510,7 @@ export const loopBreakNode = {
type: WorkflowType.LoopBreakNode,
text: t('views.applicationWorkflow.nodes.loopBreakNode.text'),
label: t('views.applicationWorkflow.nodes.loopBreakNode.label'),
height: 600,
height: 100,
properties: {
width: 600,
stepName: t('views.applicationWorkflow.nodes.loopBreakNode.label'),
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has an unnecessary change that reduces the height of both loopContinueNode and loopBreakNode. This might affect their visual representation on the workflow diagram. If you want to reduce the size of these nodes, consider adjusting their width or position instead.

Optimization suggestion:
If reducing the height is intended to improve performance or simplify rendering on mobile devices, ensure that this change does not negatively impact user interaction or understanding of the flowchart design. Consider alternative solutions for smaller node dimensions if necessary.

Note that changes made after September 1, 2021, should be re-evaluated against current best practices and standards for workflow development tools.

Expand Down
Loading