Skip to content

fix: The restriction on simple application questioning is not effective #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 25, 2025
Merged

fix: The restriction on simple application questioning is not effective #4107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/serializers/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def to_base_pipeline_manage_params(self):
'search_mode': self.application.knowledge_setting.get('search_mode') or 'embedding',
'no_references_setting': self.get_no_references_setting(self.application.knowledge_setting, model_setting),
'workspace_id': self.application.workspace_id,
'application_id': self.application.id,
'application_id': self.application_id,
'mcp_enable': self.application.mcp_enable,
'mcp_tool_ids': self.application.mcp_tool_ids,
'mcp_servers': self.application.mcp_servers,
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no immediate issues with the provided code snippet. It seems correct syntactically and logically. However, if "self.application_id" is a method that returns an ID but it's missing from the provided context (i.e., its implementation), there might be an error when calling this method.

As far as optimizations go:

  • Ensure that all variables referenced have been defined before they are used to avoid NameError.
  • If you're using Python 3, consider changing raw_input() to input(), which reads input strings from the user.

In summary, there are no major flaws but ensure your dependencies work properly.

Expand Down
Loading