Skip to content

fix: Unable to select loop node parameters after page refresh #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 25, 2025
Merged

fix: Unable to select loop node parameters after page refresh #4111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ui/src/workflow/nodes/loop-node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import LoopNode from './index.vue'
import { AppNode, AppNodeModel } from '@/workflow/common/app-node'
import { WorkflowType } from '@/enums/application'

class LoopNodeView extends AppNode {
constructor(props: any) {
const config = props.model.properties.config
super(props, LoopNode)
props.model.properties.config = config
}
}
class LoopModel extends AppNodeModel {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few areas where your JavaScript code can be improved:

Code Organization

  1. Import Statements: Ensure that all necessary imports are properly placed at the top of the file to increase readability.

  2. Class Declarations: If multiple classes have similar properties or methods, consider consolidating them into a parent class and extending it with specific implementations.

  3. Const/Let Declaration Usage: Use const for constants that will not change after their initialization and let for variables whose values might change within a function scope.

  4. Property Accessors: Consider using getter/setter methods for more robust property management, especially if you plan to perform additional logic on accessors or modifications.

Logic Flows

  1. Properties Assignment: Ensure that modifying the props.model.properties.config is done correctly. Sometimes, deep cloning might be required depending on how the configuration object is structured and used elsewhere in the application.

  2. Comments and Documentation: Add comments to explain complex parts of the code, such as why certain conditions are checked or what specific functionality each part serves.

  3. Validation and Error Handling: Include basic validation logic for inputs to avoid unexpected errors during runtime. This could involve checking if mandatory fields are present and validating data formats.

  4. Error Messages and Logging: Implement user-friendly error messages and logging mechanisms to help diagnose issues effectively.

Future-Proofing

  1. Type Safety: As TypeScript has been introduced as an option, switch to type annotations for better safety and clarity. This improves IntelliSense support and reduces runtime errors due to incorrect types.

  2. Performance Optimizations: Analyze performance bottlenecks, particularly if this component handles large datasets or performs intensive computations. Consider optimizing loops or algorithms used internally.

  3. Dependency Management: Ensure that all dependencies used (e.g., Vue.js) are compatible with the latest updates, given future releases might introduce new features or breaking changes.

  4. Testing Strategy: Develop comprehensive testing strategies for edge cases and potential bugs. Automated unit tests can help catch issues early when refactoring or developing new features.

By addressing these points, you can enhance the maintainability, functionality, and reliability of your codebase.

Expand Down
Loading