Skip to content

fix: Drift of the loop body during each refresh in the canvas #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 26, 2025
Merged

fix: Drift of the loop body during each refresh in the canvas #4116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/workflow/nodes/loop-node/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ const mountLoopBodyNode = () => {
}
if (props.nodeModel.properties.node_data.loop) {
x = props.nodeModel.properties.node_data.loop.x
y = props.nodeModel.properties.node_data.loop.y - 330
y = props.nodeModel.properties.node_data.loop.y
}
const nodeModel = props.nodeModel.graphModel.addNode({
type: loopBodyNode.type,
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has a few minor improvements that can be made:

  1. Consistent Variable Declarations: The variable type should match the property name in the object being passed to graphModel.addNode(). In this case, it is defined as loopBodyNode.type, but later used with type.

  2. Redundant Assignment: The line y = props.nodeModel.properties.node_data.loop.y - 330; will always result in the same value because y is not reassigned anywhere else within the function.

Here's the revised version:

const mountLoopBodyNode = () => {
  if (props.nodeModel.properties.node_data.loop) {
    const { x, y } = props.nodeModel.properties.node_data.loop;
  } else {
    // Handle the case when loop data is missing
    x = undefined;
    y = undefined;
  }

  const nodeType = loopBodyNode.type;

  const nodeModel = props.nodeModel.graphModel.addNode({
    type: nodeType,
    x,
    y,
  });
};

Additionally, you might want to consider adding comments or error handling for cases where loopData might be null or undefined.

Expand Down
Loading