Skip to content

fix: Chat log add to knowledge error #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Sep 29, 2025
Merged

fix: Chat log add to knowledge error #4135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/views/application_chat_record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class ApplicationChatRecordAddKnowledge(APIView):
CompareConstants.AND),
RoleConstants.WORKSPACE_MANAGE.get_workspace_role())
def post(self, request: Request, workspace_id: str, application_id: str):
return result.success(ApplicationChatRecordAddKnowledgeSerializer().post_improve(
return result.success(ApplicationChatRecordAddKnowledgeSerializer(data = {'workspace_id': workspace_id, 'application_id': application_id, **request.data}).post_improve(
{'workspace_id': workspace_id, 'application_id': application_id, **request.data}, request=request))


Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has a few improvements. The existing post method is called on an instance of ApplicationChatRecordAddKnowledgeSerializer, which does not appear to be defined in the provided context. Assuming you want to handle POST request data directly, consider updating the serializer instantiation and passing it the combined dictionary from **request.data and {'workspace_id': workspace_id, 'application_id': application_id}. Also, using f-strings instead of string concatenation can make the code cleaner:

def post(self, request: Request, workspace_id: str, application_id: str) -> Response:
    data = {'workspace_id': workspace_id, 'application_id': application_id, **request.data}
    return result.success(
        ApplicationChatRecordAddKnowledgeSerializer(data=data).post_improve(request=request)
    )

This version avoids calling a non-existent method and uses modern Python features such as f-strings for formatting. Make sure that result.success() and ApplicationChatRecordAddKnowledgeSerializer.post_improve are correctly implemented elsewhere in your codebase.

Expand Down
Loading