Skip to content

chore: update tool_params handling in index.vue #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuruibin merged 1 commit into from
Oct 9, 2025
Merged

chore: update tool_params handling in index.vue #4154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/src/workflow/nodes/mcp-node/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
v-model="item.source"
size="small"
style="width: 85px"
@change="form_data.tool_params[form_data.params_nested] = {}"
@change="form_data.tool_params[form_data.params_nested] = {}; form_data.tool_params[form_data.params_nested][item.label.label]"
>
<el-option
:label="$t('views.applicationWorkflow.nodes.replyNode.replyContent.reference')"
Expand Down Expand Up @@ -207,6 +207,7 @@
v-model="item.source"
size="small"
style="width: 85px"
@change="form_data.tool_params[item.label.label] = ''"
>
<el-option
:label="$t('views.applicationWorkflow.nodes.replyNode.replyContent.reference')"
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the provided code snippet, I've identified a couple of potential issues:

Issue 1: Overwriting Form Data Immediately After Changes

In both cases where an @change event is triggered on the select component, you're immediately overwriting all parameters under form_data.tool_params[form_data.params_nested]. If this nested object contains multiple properties or values, it might lead to loss of previously set data.

Suggestion: Change the line

form_data.tool_params[form_data.params_nested] = {};

to

const currentParams = form_data.tool_params[form_data.params_nested];
// Ensure params exists before merging with new item label value
if (currentParams) {
    currentParams[item.label.label] = '';
} else {
    form_data.tool_params[form_data.params_nested] = { [item.label.label]: '' };
}

This prevents overwriting other keys in params_nested, ensuring that only necessary changes are made.

Optimizations

Avoiding Redundant Operations in Select Component

The first version of the change handler already clears the entire nested object (tool_params) when source changes. However, if another parameter within the same level needs to be preserved after changing one, you could add conditional logic within this approach to avoid resetting non-relevant keys.

Note: If there's a specific requirement that all child nodes of params_nested need to reset every time its parent source changes, then the above modification aligns with your intentions. Otherwise, consider whether additional conditional checks can help manage updates more precisely at different levels.

Expand Down
Loading