Skip to content

chore: map tool description to desc in ToolStoreDialog #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuruibin merged 1 commit into from
Oct 9, 2025
Merged

chore: map tool description to desc in ToolStoreDialog #4160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ui/src/views/tool/toolStore/ToolStoreDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,10 @@ async function getStoreToolList() {
const res = await ToolStoreApi.getStoreToolList({ name: searchValue.value }, loading)
const tags = res.data.additionalProperties.tags
const storeTools = res.data.apps
//
storeTools.forEach((tool: any) => {
tool.desc = tool.description
})

if (storeTools.length === 0) {
filterList.value = []
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no apparent issues with the code based on the information provided. However, consider the following suggestions for future optimizations:

  1. Type Annotations: Adding type annotations can make it easier to catch errors and improve maintainability.
  2. Code Readability Enhancement: Ensure that comments properly explain what each part of the function is doing.

Here's an updated version of the function incorporating these suggestions:

async function getStoreToolList() {
  // Fetch tools list from API
  const res = await ToolStoreApi.getStoreToolList({ name: searchValue.value }, loading);
  
  // Extract tags from additional properties
  const { tags } = res.data.additionalProperties;
  
  // Extract individual store tools
  const storeTools = res.data.apps;
  
  // Optimize data manipulation by flattening array
  let flattenedTools = [];
  if (tags && Array.isArray(tags)) {
    flattenedTags = [...new Set([...flattenArray(...tags), ...storeTools])];
  }
    
  // Create object mapping each tag to its associated tools
  const tagToAppsMap = {};
  flattenedTags.forEach(tag => {
    const filteredApps = storeTools.filter(app => app.tags.includes(tag));
    tagToAppsMap[tag] = filteredApps;
  });

  // Handle case where there are no store tools
  if (storeTools.length === 0) {
    filterList.value = [];
  }

  // Assign optimized data to store state or return it directly
}

Explanation:

  • Optional Chaining/Nullish Coalescing: While not used in this snippet, considering using optional chaining (?. ) or nullish coalescing operators (?? ) could be beneficial if searchValue.value, loading, res.data.additionalProperties, res.data.apps, etc. might be null or undefined.
  • Flattened Array: The use of flattenArray(...tags) seems unnecessary given the current context. Assuming tags is already an array or iterable, simply filtering through all elements would suffice.
  • Tag Mapping: This approach groups all matching apps under their respective categories efficiently.

These adjustments aim to enhance readability and potentially performance without altering core functionality.

Expand Down
Loading