Skip to content

fix: The discriminator is empty and the judgment is incorrect #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 10, 2025
Merged

fix: The discriminator is empty and the judgment is incorrect #4166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/application/flow/compare/is_null_compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,7 @@ def support(self, node_id, fields: List[str], source_value, compare, target_valu
return True

def compare(self, source_value, compare, target_value):
return source_value is None or len(source_value) == 0
try:
return source_value is None or len(source_value) == 0
except Exception as e:
return False
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided compare method has a potential enhancement to improve exception handling and readability:

def compare(self, source_value, compare, target_value):
    try:
        return source_value is None or not bool(len(source_value))
    except Exception as e:
        # Log the exception for debugging purposes if necessary
        print(f"Error in compare: {e}")
        return False

This modification uses Python's built-in boolean conversion with bool() on the length of source_value, which makes the code more concise and easier to understand. The logging line allows you to track any unexpected errors that occur during execution without the program crashing abruptly.

Additionally, ensure that all function signatures match the expected parameters required by your application logic. If the function is part of an API where these values must conform to specific types, additional checks can be added.

Loading