Skip to content

fix: Typos error #4187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Oct 14, 2025
Merged

fix: Typos error #4187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ui/src/views/system/resource-authorization/constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ const permissionOptions = [
]


const getPermissionOptions = (isFodler = false, isRootFolder = false) => {
if (isFodler && isRootFolder) {
const getPermissionOptions = (isFolder = false, isRootFolder = false) => {
if (isFolder && isRootFolder) {
return permissionOptions.filter(
item => item.value === AuthorizationEnum.VIEW || item.value === AuthorizationEnum.MANAGE
)
}
if (isFodler) {
if (isFolder) {
return permissionOptions
}
if (hasPermission([EditionConst.IS_EE, EditionConst.IS_PE], 'OR')) {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code looks generally correct for handling different permission options based on whether an entity is a folder, root folder, or does not have specific permissions. However, there are some minor issues that could be addressed:

  1. Misnaming: Variable naming consistency is important for readability and maintainability. Using isFolder instead of both isFodler would make the function signature more uniform.

  2. Comments: While comments can help clarify the logic, they should be concise and relevant to the code. In this case, the comment could be refined.

Here's the revised version with these suggestions:

const permissionOptions = [
]

const getPermissionOptions = (isFolder = false, isRootFolder = false) => {
  if (isFolder && isRootFolder) {
    return permissionOptions.filter(item => item.value === AuthorizationEnum.VIEW || item.value === AuthorizationEnum.MANAGE)
  }
  if (isFolder) {
    return permissionOptions
  }
  if (hasPermission([EditionConst.IS_EE, EditionConst.IS_PE], 'OR')) { 
    // Additional checks here
  }
}

These changes ensure better coding practices, making it easier to understand the purpose and usage of the function.

Expand Down
Loading