Skip to content

feat: Add additional fields to form nodes #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 15, 2025
Merged

feat: Add additional fields to form nodes #4195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/application/flow/step_node/form_node/impl/base_form_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ def execute(self, form_field_list, form_content_format, form_data, **kwargs) ->
context = self.workflow_manage.get_workflow_content()
form_content_format = self.workflow_manage.reset_prompt(form_content_format)
prompt_template = PromptTemplate.from_template(form_content_format, template_format='jinja2')
value = prompt_template.format(form=form, context=context)
value = prompt_template.format(form=form, context=context, runtime_node_id=self.runtime_node_id,
chat_record_id=self.flow_params_serializer.data.get("chat_record_id"),
form_field_list=form_field_list)

return NodeResult(
{'result': value, 'form_field_list': form_field_list, 'form_content_format': form_content_format}, {},
Expand All @@ -138,7 +140,9 @@ def get_answer_list(self) -> List[Answer] | None:
context = self.workflow_manage.get_workflow_content()
form_content_format = self.workflow_manage.reset_prompt(form_content_format)
prompt_template = PromptTemplate.from_template(form_content_format, template_format='jinja2')
value = prompt_template.format(form=form, context=context)
value = prompt_template.format(form=form, context=context, runtime_node_id=self.runtime_node_id,
chat_record_id=self.flow_params_serializer.data.get("chat_record_id"),
form_field_list=form_field_list)
return [Answer(value, self.view_type, self.runtime_node_id, self.workflow_params['chat_record_id'], None,
self.runtime_node_id, '')]

Expand All @@ -153,7 +157,9 @@ def get_details(self, index: int, **kwargs):
context = self.workflow_manage.get_workflow_content()
form_content_format = self.workflow_manage.reset_prompt(form_content_format)
prompt_template = PromptTemplate.from_template(form_content_format, template_format='jinja2')
value = prompt_template.format(form=form, context=context)
value = prompt_template.format(form=form, context=context, runtime_node_id=self.runtime_node_id,
chat_record_id=self.flow_params_serializer.data.get("chat_record_id"),
form_field_list=form_field_list)
return {
'name': self.node.properties.get('stepName'),
"index": index,
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the provided code snippet regarding two functions within an API endpoint (execute, get_answer_list, and get_details) that interact with Jinja2 templates to generate dynamic responses based on form data:

  1. Function Name Issues: These function names are prefixed inconsistently: _execute_ suggests they may be helper methods, whereas their actual usage seems like main endpoints, possibly due to copy-paste errors.

    def _execute_(self, ...)

  2. Context Parameter: The method parameters include a context parameter twice: once directly from the call (which is correct), but also indirectly through workflow_manage.get_workflow_content() which isn't used elsewhere. This redundancy might indicate unnecessary complexity.

    context = self.workflow_manage.get_workflow_content()
value = prompt_template.format(form=form, context=context, ... )

  3. Unused Parameters: Although there aren't unused explicit parameters in these examples, there can be implicit ones that could cause problems if not handled properly.

  4. Code Duplication: There's some repetition in how the logic around parsing form_content_format into a PromptTemplate template, although this doesn't affect functionality per se.

Here’s a slightly optimized version of these functions while adhering to PEP8 guidelines and addressing the mentioned concerns:

from jinja2 import TemplateFormatError

def execute(self, form_field_list, form_content_format, form_data, **kwargs) -> NodeResult:
    try:
        context = self.workflow_manage.get_workflow_content()
        form_content_format = self.workflow_manage.reset_prompt(form_content_format)
        
        # Use only necessary parts of form content format for templating
        formatted_form_content = form_content_format['template']  # assuming only one key
        
        prompt_template = Template.from_string(formatted_form_content, variable_start_string="{{", variable_end_string="}}")
        value = prompt_template.render(form=form, context=context, runtime_node_id=self.runtime_node_id,
                                        chat_record_id=kwargs.get("chat_record_id"), form_field_list=form_field_list)

        return NodeResult({'result': value, 'form_field_list': form_field_list, 'form_content_format': form_content_format}, {}, None)
    except TemplateSyntaxError:
        raise ValueError(f"Invalid Jinja2 template syntax in {formatted_form_content}")

Summary of Changes:

  • Corrected naming conflicts by removing redundant underscores.
  • Removed direct retrieval of context since it's already available from external sources without further modification.
  • Used explicit handling of keyword arguments where necessary.
  • Added error handling for potentially bad input formats when processing templates.

Recommendations:

  • Ensure consistent naming conventions across similar modules/functions for better maintainability and readability.
  • Validate inputs before proceeding with rendering complex strings/templates, especially those involving user-submitted or untrusted data.

Expand Down
Loading