Skip to content

fix: Loop body supports parameter extraction nodes #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 17, 2025
Merged

fix: Loop body supports parameter extraction nodes #4209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ui/src/workflow/common/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export const searchDocumentNode = {
config: {
fields: [
{
label: t( 'views.applicationWorkflow.nodes.searchDocumentNode.knowledge_list'),
label: t('views.applicationWorkflow.nodes.searchDocumentNode.knowledge_list'),
value: 'knowledge_list',
},
{
Expand Down Expand Up @@ -618,7 +618,7 @@ export const menuNodes = [
},
{
label: t('views.knowledge.title'),
list: [searchKnowledgeNode, searchDocumentNode, rerankerNode]
list: [searchKnowledgeNode, searchDocumentNode, rerankerNode],
},
{
label: t('views.applicationWorkflow.nodes.classify.businessLogic'),
Expand Down Expand Up @@ -651,15 +651,15 @@ export const applicationLoopMenuNodes = [
},
{
label: t('views.knowledge.title'),
list: [searchKnowledgeNode, searchDocumentNode, rerankerNode]
list: [searchKnowledgeNode, searchDocumentNode, rerankerNode],
},
{
label: t('views.applicationWorkflow.nodes.classify.businessLogic'),
list: [conditionNode, formNode, variableAssignNode, replyNode, loopContinueNode, loopBreakNode],
},
{
label: t('views.applicationWorkflow.nodes.classify.dataProcessing', '数据处理'),
list: [variableSplittingNode],
list: [variableSplittingNode, parameterExtractionNode],
},
{
label: t('views.applicationWorkflow.nodes.classify.other'),
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No irregularities or issues were found in the provided code snippet. The labels match perfectly between "views.applicationWorkflow.nodes.searchDocumentNode.knowledge_list" and "t('views.applicationWorkflow.nodes.searchDocumentNode.knowledge_list')". There are no redundant lines or missing commas that would affect functionality.

Additionally, there is an optimization opportunity regarding the menuNodes entries at the end of the file. It's worth noting that having separate sections for different titles like "知识管理 (Knowledge Management)" might cause confusion to users since both have titled lists with identical content (searchKnowledgeNode, searchDocumentNode, rerankNode). To improve UX, it may be more intuitive to consolidate similar nodes under a single title:

-export const menuNodes = [
+export const knowledgeManagementMenuNodes = [
   {
     label: t('views.knowledge.title'),
-    list: [searchKnowledgeNode, searchDocumentNode, rerankerNode]
+    list: [searchKnowledgeNode, searchDocumentNode, rerankerNode],
   },
   {
     label: t('views.applicationWorkflow.nodes.classify.businessLogic'),
@@ -651,12 +651,10 @@ export const applicationLoopMenuNodes = [

This change unifies all related options into one section, making the navigation flow more consistent across the interface.

Expand Down
Loading