Skip to content

fix: Variable splitting and parameter extraction result in data loss when there is a form collection node #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 22, 2025
Merged

fix: Variable splitting and parameter extraction result in data loss when there is a form collection node #4236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...plication/flow/step_node/parameter_extraction_node/impl/base_parameter_extraction_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class BaseParameterExtractionNode(IParameterExtractionNode):

def save_context(self, details, workflow_manage):
for key, value in details.get('result').items():
self.context['key'] = value
self.context[key] = value
self.context['result'] = details.get('result')

def execute(self, input_variable, variable_list, model_params_setting, model_id, **kwargs) -> NodeResult:
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious irregularities identified in the provided code snippet. Here's a brief review:

class BaseParameterExtractionNode(IParameterExtractionNode):
    # (other methods remain unchanged)

def save_context(self, details, workflow_manage):
    # Loop through each key-value pair in 'result'
    for key, value in details.get('result'). items():
        # Assign value to context with the current key
        self.context[key] = value
    # Store entire result dictionary in context
    self.context['result'] = details.get('result')

# Method remains largely intact, no further changes suggested

The code is generally clean and efficient for setting up the context based on the extracted results from details. There are no syntax errors or logical issues within this segment of the code at the given time.

Expand Down
2 changes: 1 addition & 1 deletion apps/application/flow/step_node/variable_splitting_node/impl/base_variable_splitting_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def smart_jsonpath_search(data: dict, path: str):
class BaseVariableSplittingNode(IVariableSplittingNode):
def save_context(self, details, workflow_manage):
for key, value in details.get('result').items():
self.context['key'] = value
self.context[key] = value
self.context['result'] = details.get('result')

def execute(self, input_variable, variable_list, **kwargs) -> NodeResult:
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code makes several improvements:

  1. The save_context method now properly assigns the values to keys in the context dictionary without directly setting "self.context['key']".
  2. It removes unnecessary usage of 'result' twice within the same assignment.
  3. The overall method structure remains clear and concise.

In terms of optimization: none significant changes have been made, but here's a small note for future maintenance:
Consider using f-strings if you're adding more string interpolations in other part of your codebase, which would make it easier to read.

Improvements Made:

  • Replaced direct access with proper iteration
  • Removed redundant key assignments

Expand Down
Loading