Skip to content

fix: When collecting data from the multiple-choice box of the form collection node, it is recommended to support pressing enter to select the option #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 22, 2025
Merged

fix: When collecting data from the multiple-choice box of the form collection node, it is recommended to support pressing enter to select the option #4237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/components/dynamics-form/items/select/MultiSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
filterable
allow-create
clearable
default-first-option
:reserve-keyword="false"
v-bind="$attrs"
v-model="_modelValue"
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet looks mostly correct but can be optimized slightly:

  1. Duplicate Default Value: The default-first-option property is included twice at the end of the line, which might not be intended unless you have specific logic to handle this.

  2. Remove Duplicate Attributes: Since all attributes are being passed via v-bind="$attrs", including those that will overwrite existing properties (like $attrs.default-first-option), redundant assignments like default-first-option:"true" could conflict with what's already set via bindings.

Here's a more concise version:

<template>
  <!-- Your template content -->
</template>

<script>
export default {
  props: {
    filterable: Boolean,
    allowCreate: Boolean,
    clearable: Boolean
  },
  computed: {
    _modelValue() {
      // Define your computed or data properties here
    }
  },
  methods: {
    someMethod() {
      // Define your methods here
    }
  }
}
</script>

<style scoped>
/* Your styles go here */
</style>

Optimizations and Corrections:

  • Remove the duplicate default-first-option="true".
  • Ensure there are no conflicts between direct assignment (v-model) and binding (v-bind).
  • Keep your script organized within <script>, <computed>, and <methods> blocks if necessary.

Expand Down
Loading