Skip to content

fix: The parameter extraction node does not display input parameters in the execution details #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 22, 2025
+6 −0
Merged

fix: The parameter extraction node does not display input parameters in the execution details #4239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...plication/flow/step_node/parameter_extraction_node/impl/base_parameter_extraction_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ def save_context(self, details, workflow_manage):
for key, value in details.get('result').items():
self.context[key] = value
self.context['result'] = details.get('result')
self.context['request'] = details.get('request')

def execute(self, input_variable, variable_list, model_params_setting, model_id, **kwargs) -> NodeResult:
self.context['request'] = input_variable
if model_params_setting is None:
model_params_setting = get_default_model_params_setting(model_id)
workspace_id = self.workflow_manage.get_body().get('workspace_id')
Expand All @@ -106,6 +108,7 @@ def get_details(self, index: int, **kwargs):
"index": index,
'run_time': self.context.get('run_time'),
'type': self.node.type,
'request': self.context.get('request'),
'result': self.context.get('result'),
'status': self.status,
'err_message': self.err_message
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are two issues. You forgot to add 'self' before calling methods on workflow_manage. The second issue is that you're trying to access keys from self.context that don't exist when they should be set.

Here's the corrected code:

@@ -88,8 +88,10 @@ def save_context(self, details, workflow_manage):
     for key, value in details.get('result').items():
         self.context[key] = value
     self.context['result'] = details.get('result')

  •    self.context['request'] = details.get('request', '')

    def execute(self, input_variable, variable_list, model_params_setting, model_id, **kwargs) -> NodeResult:

  •    # Make sure context request doesn't error out when it shouldn't.

  •    self.request = kwargs.get('request') if isinstance(input_variable, dict) and 'request' in input_variable else ''
       
   if model_params_setting is None:
       model_params_setting = get_default_model_params_setting(model_id)
   workspace_id = self.workflow_manage.get_body().get('workspace_id')

@@ -106,6 +108,7 @@ def get_details(self, index: int, **kwargs):
"index": index,
'run_time': self.context.get('run_time'),
'type': self.node.type,

  •        'request': self.context.get('request'), # Corrected this line
       'result': self.context.get('result'),
       'status': self.status,
       'err_message': self.err_message

Expand Down
3 changes: 3 additions & 0 deletions apps/application/flow/step_node/variable_splitting_node/impl/base_variable_splitting_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ def save_context(self, details, workflow_manage):
for key, value in details.get('result').items():
self.context[key] = value
self.context['result'] = details.get('result')
self.context['request'] = details.get('request')

def execute(self, input_variable, variable_list, **kwargs) -> NodeResult:
self.context['request'] = input_variable
response = {v['field']: smart_jsonpath_search(input_variable, v['expression']) for v in variable_list}
return NodeResult({'result': response, **response}, {})

Expand All @@ -47,6 +49,7 @@ def get_details(self, index: int, **kwargs):
"index": index,
'run_time': self.context.get('run_time'),
'type': self.node.type,
'request': self.context.get('request'),
'result': self.context.get('result'),
'status': self.status,
'err_message': self.err_message
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In the save_context method, adding 'request' to the context dictionary ensures that all necessary data is stored.
  2. It's a good practice to initialize all variables used within methods before they are accessed.
  3. Consider using more descriptive variable names to improve code readability.
  4. Adding logging could be beneficial during debugging.

Expand Down
Loading