Skip to content

fix: Parameter configuration function #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Oct 27, 2025
Merged

fix: Parameter configuration function #4259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ui/src/views/system-resource-management/ModelResourceIndex.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,7 @@
<el-dropdown-item
@click.stop="openParamSetting(row)"
v-if="
(row.model_type === 'TTS' ||
row.model_type === 'LLM' ||
row.model_type === 'IMAGE' ||
row.model_type === 'TTI') &&
['TTS','LLM','IMAGE','TTI','STT','RERANKER'].includes(row.model_type) &&
permissionPrecise.paramSetting()
"
>
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the code snippet provided. The permissionPrecise object does not have a method named paramSetting(). Typically, this might be a property that returns a boolean value indicating whether the user has permissions to settings.

Potential Improvements:

  1. Check if permissionPrecise.paramSetting() Returns Boolean:
    Ensure that permissionPrecise.paramSetting() returns either true or false based on the user's permissions.

  2. Add Fallback or Debugging Statements:
    Add some logging or conditionals to handle cases where permissionPrecise.paramSetting() might return undefined or other unexpected values:

            <el-dropdown-item
          @click.stop="openParamSetting(row)"
          v-if="
            ['TTS', 'LLM', 'IMAGE', 'TTI', 'STT', 'RERANKER'].includes(row.model_type)
              && (!_.isUndefined(permissionPrecise.paramSetting()) || _.isNull(permissionPrecise.paramSetting()))
              && permissionPrecise.paramSetting()
          "
        >

  3. Ensure Correct Method Call:
    Double-check the structure of the object to ensure that you're calling the correct method (paramSetting) correctly.

  4. Consider Using Vuex for State Management:
    If the logic involving permissionPrecise is spread across multiple parts of the application, consider using Vuex for better state management.

Here’s a cleaned-up version incorporating these improvements:

<template>
  <ul class="tree-view">
    <!-- Other tree nodes -->
    <li>
      <div v-if="
        row.model_type === 'TTS' ||
        row.model_type === 'LLM' ||
        row.model_type === 'IMAGE' ||
        row.model_type === 'TTI' ||
        row.model_type === 'STT' ||
        row.model_type === 'RERANKER'
      ">
        <slot name="label" :node="row"></slot><span class="expand-button expand-icon"
          ><i aria-hidden="true" role="img" style="cursor: pointer;"
            :class="expanded ? 'fa-minus-square-o' : 'fa-plus-square-o'"
          ></i></span
        ><span class="count-info">{{ total }}</span>
        <el-tree

Expand Down
Loading