Skip to content

fix: Folder and Resource Selection Interaction Abnormality #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 27, 2025
Merged

fix: Folder and Resource Selection Interaction Abnormality #4260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ui/src/views/system/resource-authorization/component/PermissionTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,10 @@ const select = (val: any[], active: any) => {
TreeToFlatten([active])
.filter((item: any) => item.id != active.id)
.forEach((item: any) => {
multipleTableRef.value?.toggleRowSelection(item, true)
if (multipleSelection.value.some((select) => item.id == select.id)) {
multipleTableRef.value?.toggleRowSelection(item, true)
}
})

multipleSelection.value = multipleTableRef.value.getSelectionRows()
} else {
multipleSelection.value = val
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you've provided is mostly correct with some minor optimizations and improvements:

  1. Simplified Condition: The condition inside the if statement can be simplified to directly check if an item exists in multipleSelection. This avoids iterating over the entire array twice.

Here's your updated code with this optimization:

const select = (val: any[], active: any) => {
  TreeToFlatten([active])
    .filter((item: any) => item.id !== active.id)
    .forEach((item: any) => {
      const isSelected = multipleSelection.value.some(s => s.id === item.id);
      
      // Toggle row selection only if it is not already selected
      if (!isSelected && multipleTableRef.value)
        multipleTableRef.value.toggleRowSelection(item, true);
    });

  multipleSelection.value = multipleTableRef.value.getSelectionRows();
};

Key Improvements:

  • Single Iteration Check: Reduced the need for filtering out items that cannot exist in multipleSelection.
  • Direct Selection Check: Use some() to check if an item is already selected without needing to iterate further through multipleSelection.

These changes make the function more efficient while maintaining its functionality.

Expand Down
Loading