Skip to content

fix: After uploading the file, ask a question. After completing the question and answer, change the answer and the file will not be uploaded again, resulting in the loss of file information #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 27, 2025
Merged

fix: After uploading the file, ask a question. After completing the question and answer, change the answer and the file will not be uploaded again, resulting in the loss of file information #4269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ui/src/components/ai-chat/component/answer-content/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,16 +156,17 @@ function showSource(row: any) {
}

const regenerationChart = (chat: chatType) => {
const startNode = props.chatRecord.execution_details?.find(
(detail) => detail.type === 'start-node',
)
const container = props.chatRecord?.upload_meta
? props.chatRecord.upload_meta
: props.chatRecord.execution_details?.find((detail) => detail.type === 'start-node')

props.sendMessage(chat.problem_text, {
re_chat: true,
image_list: startNode?.image_list || [],
document_list: startNode?.document_list || [],
audio_list: startNode?.audio_list || [],
video_list: startNode?.video_list || [],
other_list: startNode?.other_list || [],
image_list: container?.image_list || [],
document_list: container?.document_list || [],
audio_list: container?.audio_list || [],
video_list: container?.video_list || [],
other_list: container?.other_list || [],
})
}
const stopChat = (chat: chatType) => {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears to be part of an application that generates a regeneration chart for a chat session based on specific details. Here’s a summary and some suggestions:

Summary of Code

  1. Function showSource: This function seems to handle displaying source information from a row object.

  2. Function regenerationChart:

    • It takes a chatType as input.
    • It identifies the 'start-node' execution detail using props.chatRecord.execution_details.
    • Depending on whether there is an upload metadata (props.chatRecord.upload_meta) present, it uses this for container data; otherwise, it falls back to finding the 'start-node' in the execution details.
    • It then sends a message using props.sendMessage, passing parameters like problem text, re-chat setting, image lists, document lists, audio lists, video lists, and other lists extracted from either container or the fallback.

  3. Function stopChat: No changes suggested here apart from its placeholder nature.

Suggestions

  1. Error Handling: Ensure proper error handling for cases where props.chatRecord.execution_details or props.chatRecord.upload_meta might not exist. Consider returning early if any necessary objects are missing.

  2. Code Clarity: The use of variables like container makes the code cleaner and more readable compared to nesting multiple conditions directly within the sendMessage call.

  3. Avoid Redundancy: If certain lists may always have default values even when empty (e.g., no image list), you could simplify the defaults slightly: image_list || [].

  4. Documentation: Add comments to elaborate on the purpose of each section and why particular decisions were made.

Overall, the code is well structured and functional, but with these minor improvements can enhance both readability and robustness.

Expand Down
Loading