Skip to content

fix: Resource authorization: "Select All" is ineffective #4274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 28, 2025
Merged

fix: Resource authorization: "Select All" is ineffective #4274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ui/src/views/system/resource-authorization/component/PermissionTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,14 @@
class="mt-16"
:data="filteredData"
@select="select"
@select-all="selectAll"
:maxTableHeight="260"
:row-key="(row: any) => row.id"
style="min-width: 600px"
:expand-row-keys="defaultExpandKeys"
show-overflow-tooltip
>
<el-table-column type="selection" width="55" :reserve-selection="true" />
<el-table-column type="selection" width="55" :reserve-selection="true"> </el-table-column>
<el-table-column prop="name" :label="$t('common.name')">
<template #default="{ row }">
<span style="vertical-align: sub">
Expand Down Expand Up @@ -137,7 +138,7 @@
</div>
</template>
<script setup lang="ts">
import { ref, onMounted, watch, computed, reactive } from 'vue'
import { ref, onMounted, computed, nextTick } from 'vue'
import { useRoute } from 'vue-router'
import type { Provider } from '@/api/type/model'
import { SourceTypeEnum } from '@/enums/common'
Expand Down Expand Up @@ -312,6 +313,9 @@ const filteredData = computed(() => {

const multipleSelection = ref<any[]>([])
const selectObj: any = {}
const selectAll = (selection: any[]) => {
multipleSelection.value = selection
}
const select = (val: any[], active: any) => {
if (active.resource_type === 'folder') {
if (!val.some((item) => item.id == active.id)) {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks mostly correct, but there are a few minor improvements and suggestions:

  1. Suggested Changes:

    • Replace the @select-all event with a more conventional name like onSelectAll. ThisChangeEvent makes it clear what this method does.

  2. Optimization Suggestions:

    • Use nextTick() before modifying data in lifecycle hooks that depend on DOM rendering to ensure all changes have been applied. In your selectAll method, you can add await nextTick() after setting multipleSelection.

Here's how the updated code could look:

<template>
  <div>
    <!-- Component template remains unchanged -->
  </div>
</template>

<script setup lang="ts">
import { ref, onMounted, computed, nextTick } from 'vue' // Use import statement instead of require
import { useRoute } from 'vue-router'
import type { Provider } from '@/api/type/model'
import { SourceTypeEnum } from '@/enums/common'

// Existing code logic remains intact

const filteredData = computed(() => {
  return data.filter(item => !showTrash || item.is_trash !== true);
});

const multipleSelection = ref<any[]>([]);
const selectObj: any = {};
// Update onSelectAll event handler
const onSelectAll = (selection: any[]) => {
  await nextTick(); // Ensure DOM updates
  multipleSelection.value = selection;
};
// Updated select function
const select = (val: any[], active: any) => {
  if (active.resource_type === 'folder') {
    if (!val.some((item) => item.id == active.id)) {
      val.push(active);
    }
  } else {
    if (!val.includes(active.row)) { // Corrected comparison logic
      val.push(Object.assign({}, active));
      
    }

// ... Rest of the update ...

These changes should make the code cleaner and potentially enhance performance depending on the complexity of your application.

Expand Down
Loading