Skip to content

chore: update document deletion logic to handle paragraph IDs and related mappings #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuruibin merged 1 commit into from
Nov 3, 2025
+14 −9
Merged

chore: update document deletion logic to handle paragraph IDs and related mappings #4306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/knowledge/serializers/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,10 +683,11 @@ def delete(self):
]
QuerySet(File).filter(id__in=source_file_ids).delete()
QuerySet(File).filter(source_id=document_id, source_type=FileSourceType.DOCUMENT).delete()
paragraph_ids = QuerySet(model=Paragraph).filter(document_id=document_id).values_list("id", flat=True)
# 删除问题
delete_problems_and_mappings(paragraph_ids)
# 删除段落
QuerySet(model=Paragraph).filter(document_id=document_id).delete()
# 删除问题
delete_problems_and_mappings([document_id])
# 删除向量库
delete_embedding_by_document(document_id)
QuerySet(model=DocumentTag).filter(document_id=document_id).delete()
Expand Down Expand Up @@ -1217,9 +1218,12 @@ def batch_delete(self, instance: Dict, with_valid=True):
Document.objects.filter(id__in=document_id_list).values("meta")]
QuerySet(File).filter(id__in=source_file_ids).delete()
QuerySet(Document).filter(id__in=document_id_list).delete()
QuerySet(Paragraph).filter(document_id__in=document_id_list).delete()
QuerySet(DocumentTag).filter(document_id__in=document_id_list).delete()
delete_problems_and_mappings(document_id_list)
paragraph_ids = QuerySet(Paragraph).filter(document_id__in=document_id_list).values_list("id", flat=True)
# 删除问题关系
delete_problems_and_mappings(paragraph_ids)
# 删除段落
QuerySet(Paragraph).filter(document_id__in=document_id_list).delete()
# 删除向量库
delete_embedding_by_document_list(document_id_list)
return True
Expand Down
11 changes: 6 additions & 5 deletions apps/knowledge/sql/list_problem.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
SELECT
problem.*,
(SELECT "count"("id") FROM "problem_paragraph_mapping" WHERE problem_id="problem"."id") as "paragraph_count"
FROM
problem problem
SELECT problem.*,
(SELECT COUNT(ppm.id)
FROM problem_paragraph_mapping ppm
INNER JOIN paragraph p ON ppm.paragraph_id = p.id
WHERE ppm.problem_id = problem.id) AS "paragraph_count"
FROM problem problem
Loading