Skip to content

fix: After adding form collection at the loop node, the variables from subsequent nodes in the loop become empty #4351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Nov 12, 2025
Merged

fix: After adding form collection at the loop node, the variables from subsequent nodes in the loop become empty #4351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/application/flow/step_node/loop_node/impl/base_loop_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,14 @@ class BaseLoopNode(ILoopNode):
def save_context(self, details, workflow_manage):
self.context['loop_context_data'] = details.get('loop_context_data')
self.context['loop_answer_data'] = details.get('loop_answer_data')
self.context['loop_node_data'] = details.get('loop_node_data')
self.context['result'] = details.get('result')
self.context['params'] = details.get('params')
self.context['run_time'] = details.get('run_time')
self.context['index'] = details.get('current_index')
self.context['item'] = details.get('current_item')
for key, value in (details.get('loop_context_data') or {}).items():
self.context[key] = value
self.answer_text = ""

def get_answer_list(self) -> List[Answer] | None:
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you provided contains several minor improvements and optimizations. Here’s a revised version with comments:

class BaseLoopNode(ILoopNode):
    def save_context(self, details, workflow_manage: WorkflowManager):
        # Save loop-specific context data
        if 'loop_context_data' in details:
            self.context['loop_context_data'] = copy.deepcopy(details['loop_context_data'])
        
        # Ensure loop answer data is saved safely
        if 'loop_answer_data' in details:
            self.context['loop_answer_data'] = safe_copy(data)

        # Add additional loop-related context data
        if 'loop_node_data' in details:
            self.context['loop_node_data'] = safe_copy(details['loop_node_data'])

        # Save other common execution context variables
        self.context.update({
            'result': details.get('result'),
            'params': details.get('params'),
            'run_time': details.get('run_time'),
            'index': details.get('current_index', 0),
            'item': details.get('current_item')
        })

    def get_answer_list(self) -> List[Answer] | None:

Key Improvements and Optimizations:

  1. Deep Copy for loop_context_data:

    if 'loop_context_data' in details:
    self.context['loop_context_data'] = copy.deepcopy(details['loop_context_data'])

    Ensures that changes to this data do not affect the original structure.

  2. Use of copy.deepcopy() for Safeguarding Data Structure:

    import copy

def safe_copy(data):
    try:
        return copy.deepcopy(data)
    except Exception as e:
        print(f"Safe copy failed due to {e}, returning None.")
        return None

    A helper function to handle deepcopy gracefully and avoid exceptions during deep copying.

  3. Updating Context Directly:

    self.context.update({
    ...
    'index': details.get('current_index', 0),  # Default index to 0 if not existent
    ...
})

    Updates multiple context fields at once using update(), making the code cleaner and more efficient.

These enhancements help ensure the robustness and accuracy of the context handling logic within the class.

Expand Down
Loading