Skip to content

fix: Get workspace_id from workflow params #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Nov 26, 2025
Merged

fix: Get workspace_id from workflow params #4388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/flow/step_node/knowledge_write_node/impl/base_knowledge_write_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def save(self, document_list):
document_list = serializer.data

knowledge_id = self.workflow_params.get("knowledge_id")
workspace_id = "default"
workspace_id = self.workflow_params.get("workspace_id")

document_model_list = []
paragraph_model_list = []
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears to be part of a method that saves data related to documents and paragraphs. Here's my review:

  1. Variable Renaming: The workspace_id variable has been renamed from "default" to self.workflow_params.get("workspace_id"). This is appropriate if the default value might change or depend on workflow parameters.

  2. List Initialization: The initialization of both document_model_list and paragraph_model_list at the beginning seems unnecessary based on the context. They should only be initialized within the loop where they are used.

  3. Code Structure: While the function structure remains consistent, it could benefit slightly from more structured comments explaining each step of the process.

Overall, the code performs its intended task without major issues, but there’s an opportunity to optimize list initializations based on the control flow logic.

Optimized Code:

def save(self, document_list):
    # Assuming serializer.data contains valid document data
    document_list = serializer.data
    
    knowledge_id = self.workflow_params.get("knowledge_id")
    workspace_id = self.workflow_params.get("workspace_id", "default")
    
    document_models = []
    paragraph_models = []
   
    for doc_data in document_list:
        document_model = Document.objects.create(
            knowledge=knowledge_id,
            title=doc_data['title'],
            content=doc_data['content']
        )
        document_models.append(document_model)
        
        for para_data in doc_data['paragraphs']:
            paragraph_model = Paragraph.objects.create(
                document=document_model,
                text=para_data['text']
            )
            paragraph_models.append(paragraph_model)

    return {"documents": document_models, "paragraphs": paragraph_models}

In this revised version:

  • The lists documentModels and paragraphModels are initialized outside the loops.
  • Each iteration over document_list creates a Document object, adding it to document_models.
  • For each document, a corresponding list comprehension populates associated Paragraph objects into paragraph_models.

This approach improves readability by clearly separating responsibilities, reducing redundant operations, and potentially improving performance by minimizing database queries during multiple iterations.

Expand Down
Loading