Skip to content

fix: Knowledge write node height #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Dec 3, 2025
Merged

fix: Knowledge write node height #4423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/workflow/common/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ export const knowledgeWriteNode = {
type: WorkflowType.KnowledgeWriteNode,
text: t('views.workflow.nodes.knowledgeWriteNode.text'),
label: t('views.workflow.nodes.knowledgeWriteNode.label'),
height: 252,
properties: {
height: 252,
stepName: t('views.workflow.nodes.knowledgeWriteNode.label'),
config: {
fields: [],
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appears to be a function definition within an object called knowledgeWriteNode. There is a slight issue with the height property being set twice, which is unnecessary and potentially redundant.

Here's a revised version of the code:

export const knowledgeWriteNode = {
  type: WorkflowType.KnowledgeWriteNode,
  text: t('views.workflow.nodes.knowledgeWriteNode.text'),
  label: t('views.workflow.nodes.knowledgeWriteNode.label'),
+  height: 252,
  properties: {
    // Remove the duplicate 'height' field here if it's not intentionally repeated elsewhere in your codebase
    stepName: t('views.workflow.nodes.knowledgeWriteNode.label'),
    config: {
      fields: [],
    },
};

This change ensures that each key-value pair in the properties object is unique and reduces redundancy. If you have other instances where the height might also appear incorrectly in the same context, those should also be addressed accordingly.

Expand Down
Loading