Skip to content

fix: Workflow knowledge base import button error #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 3, 2025
Merged

fix: Workflow knowledge base import button error #4429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/views/document/ImportWorkflowDocument.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
{{ $t('views.document.buttons.next') }}
</el-button>
<el-button
v-if="base_form_list.length > 0 ? active == 'knowledge_base' : true"
v-if="base_form_list.length > 0 ? active == 'knowledge_base' : active == 'data_source'"
@click="upload"
type="primary"
:disabled="loading"
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has two small issues that need addressing:

  1. Logical Error: The condition active == 'knowledge_base' is followed by true, which does not make sense logically. It should be removed since v-if expressions evaluate to either true or false.

  2. Code Duplication: Using $t('views.document.buttons.next') twice with different attributes (type and :disabled) can be optimized. You can extract this static string into a variable if it's the same across these instances.

Here is the modified version of the code:

@@ -43,7 +43,7 @@
         {{ $t('views.document.buttons.next') }}
       </el-button>
       <el-button
-        v-if="base_form_list.length > 0 && active == 'knowledge_base'"
+        v-if="base_form_list.length > 0 && active == 'data_source'"
         @click="upload"
         type="primary"
         :disabled="loading"

Additionally, you might consider storing this translation key in a single place for better readability and maintainability. For example:

const next_button_label = $t('views.document.buttons.next');

This would give you more flexibility to change labels without affecting multiple locations in your codebase.

Expand Down
18 changes: 9 additions & 9 deletions ui/src/views/knowledge-workflow/component/DebugDrawer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
{{ $t('views.document.buttons.next') }}
</el-button>
<el-button
v-if="base_form_list.length > 0 ? active == 'knowledge_base' : true"
v-if="base_form_list.length > 0 ? active == 'knowledge_base' : active == 'data_source'"
@click="upload"
type="primary"
:loading="loading"
Expand Down Expand Up @@ -133,14 +133,14 @@ const permissionPrecise = computed(() => {
const upload = () => {
if (permissionPrecise.value.doc_create(id)) {
ActionRef.value.validate().then(() => {
form_data.value[active.value] = ActionRef.value.get_data()
loadSharedApi({ type: 'knowledge', systemType: apiType.value })
.workflowAction(id, form_data.value, loading)
.then((ok: any) => {
action_id.value = ok.data.id
active.value = 'result'
})
})
form_data.value[active.value] = ActionRef.value.get_data()
loadSharedApi({ type: 'knowledge', systemType: apiType.value })
.workflowAction(id, form_data.value, loading)
.then((ok: any) => {
action_id.value = ok.data.id
active.value = 'result'
})
})
} else {
MsgError(t('views.application.tip.noDocPermission'))
}
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No significant irregularities were found in the provided code. However, here are some optimization suggestions:

  1. Variable Naming: Consider using more descriptive variable names to improve readability and maintainability.

  2. Code Duplication: The else block can be simplified by moving the error message into a single function call:

if (permissionPrecise.value.doc_create(id)) {
  ActionRef.value.validate().then(() => {
    form_data.value[active.value] = ActionRef.value.get_data();
    loadSharedApi({ type: 'knowledge', systemType: apiType.value })
      .workflowAction(id, form_data.value, loading)
      .then((ok: any) => {
        action_id.value = ok.data.id;
        active.value = 'result';
      });
  });
} else {
  MsgError(t('views.application.tip.noDocPermission'));
}

To optimize further within performance constraints and reduce unnecessary computations, ensure that the API requests are efficient and do not introduce delays where non-critical tasks could wait:

  1. Throttle/Debounce: If you expect multiple calls with similar parameters during rapid user actions, consider throttling or debouncing certain parts of the logic to prevent redundant operations.

These optimizations aim to enhance both usability and efficiency while keeping the code clean and readable.

Expand Down
Loading