Skip to content

fix: After renaming the predecessor node, the variable list was not updated #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 5, 2025
Merged

fix: After renaming the predecessor node, the variable list was not updated #4452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/workflow/common/NodeContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ const editName = async (formEl: FormInstance | undefined) => {
?.some((node: any) => node.properties.stepName === form.value.title)
) {
set(props.nodeModel.properties, 'stepName', form.value.title)
props.nodeModel.clear_next_node_field(true)
nodeNameDialogVisible.value = false
formEl.resetFields()
} else {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No significant irregularities, issues, or optimizations were found in the provided code snippet. It updates an object property if it exists within an array of child nodes, sets a dialog visibility flag to false, resets field values from a form instance, and optionally clears fields on the next node after updating.

The changes include setting properties directly on props.nodeModel.properties with bracket notation for more flexibility and clearing next-node fields using ?.clear_next_node_field(true). This makes the code concise and easy to understand while meeting the requirements.

Expand Down
Loading