Skip to content

fix: In the execution details, the display order of the child nodes of the loop body is incorrect #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 8, 2025
Merged

fix: In the execution details, the display order of the child nodes of the loop body is incorrect #4461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/components/ai-chat/component/knowledge-source-component/ExecutionDetailCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,7 @@
<template
v-for="(cLoop, cIndex) in Object.values(
data.loop_node_data?.[currentLoopNode] || [],
)"
).sort((x: any, y: any) => (x.index || 0) - (y.index || 0))"
:key="cIndex"
>
<ExecutionDetailCard :data="cLoop"></ExecutionDetailCard>
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided line introduces a bug in the code. In JavaScript ES6 Object.values, when used to iterate over object properties, it returns an array of values that correspond to those properties without keys. The subsequent .sort() operation expects two parameters for comparison, but the current implementation only references one ((x: any)). To sort objects by a specific property like "index", you need to access that property within the sorting function.

Here is the corrected version of the line:

v-for="(cLoop, cIndex) in Object.values(data.loop_node_data?.[currentLoopNode] || []).sort((x: any, y: any) => (x.index || 0) - (y.index || 0))"

By adding another reference to (y.index || 0) before subtracting from each other, the function now correctly sorts the objects based on their index attribute, assuming all elements have at least an index field or default to zero if missing.

Expand Down
Loading