Skip to content

fix: [Application] When an application with form collection is embedded into the parent application, the conversation will report an error #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 9, 2025
Merged

fix: [Application] When an application with form collection is embedded into the parent application, the conversation will report an error #4472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion apps/application/serializers/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,33 @@ def append_chat_record(self, chat_record: ChatRecord):
else:
QuerySet(Chat).filter(id=self.chat_id).update(update_time=timezone.now())
# 插入会话记录
chat_record.save()
QuerySet(ChatRecord).update_or_create(id=chat_record.id,
create_defaults={'id': chat_record.id,
'chat_id': chat_record.chat_id,
"vote_status": chat_record.vote_status,
'problem_text': chat_record.problem_text,
'answer_text': chat_record.answer_text,
'answer_text_list': chat_record.answer_text_list,
'message_tokens': chat_record.message_tokens,
'answer_tokens': chat_record.answer_tokens,
'const': chat_record.const,
'details': chat_record.details,
'improve_paragraph_id_list': chat_record.improve_paragraph_id_list,
'run_time': chat_record.run_time,
'index': chat_record.index},
defaults={
"vote_status": chat_record.vote_status,
'problem_text': chat_record.problem_text,
'answer_text': chat_record.answer_text,
'answer_text_list': chat_record.answer_text_list,
'message_tokens': chat_record.message_tokens,
'answer_tokens': chat_record.answer_tokens,
'const': chat_record.const,
'details': chat_record.details,
'improve_paragraph_id_list': chat_record.improve_paragraph_id_list,
'run_time': chat_record.run_time,
'index': chat_record.index
})
ChatCountSerializer(data={'chat_id': self.chat_id}).update_chat()

def to_dict(self):
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code block contains a function append_chat_record within a class that handles appending chat records to the database while ensuring unique primary keys are assigned. The method uses Django ORM functionalities such as update_or_create and QuerySet.update. There are a few issues and recommendations for optimization:

Issues Found:

  1. Duplicate Update Statement: After checking if the record exists and updating its update_time, there's another update statement (chat_record.save()) added below it. This is not necessary because you're already using update_or_create.

    if self.chat_count == 0:
    query = QuerySet(Chat).filter(id=self.chat_id)
    if not query.first():
        query.create(create_time=timezone.now())
    else:
        QuerySet(Chat).filter(id=self.chat_id).update(update_time=timezone.now())
    # Comment out these two lines
    # chat_record.save()
# Continue with other logic here...

  2. Use of data={'chat_id': ...}, create_defaults, and defaults Parameters: While this pattern can be efficient, ensure all fields (especially the ones like const, details, etc.) required by the serializer are included in either data or defaultses.

  3. Optimize Logic with Conditionals: Consider optimizing the conditional statements where you determine whether to insert or update a record based on the existence of an existing one.

Optimization Suggestions:

  • Use Conditional Updates: Instead of creating a new row when the record does not exist and then performing updates, use QuerySet.filter() followed by update(...) directly.

  • Simplify Serialization Process: If possible, simplify how changes are made via serialization to avoid redundant operations and make debugging easier.

  • Handle Additional Fields Wisely: Ensure that fields from ChatRecord are being included correctly in create_defaults or `defaults".

By addressing these points, you can improve the readability, efficiency, and reliability of the code.

Expand Down
Loading