Skip to content

fix: Modify the parameter name and display name of the loop variable in the loop node, but the variable name is not updated in the nodes outside the loop #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 10, 2025
Merged

fix: Modify the parameter name and display name of the loop variable in the loop node, but the variable name is not updated in the nodes outside the loop #4485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/workflow/nodes/loop-body-node/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ const refresh_loop_fields = (fields: Array<any>) => {
const loop_node = props.nodeModel.graphModel.getNodeModelById(loop_node_id)
if (loop_node) {
loop_node.properties.config.fields = fields
loop_node.clear_next_node_field(true)
}
}

Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The given code seems to be related to setting and clearing properties of nodes in an application's graph model. It performs the following actions:

  1. Calls refresh_loop_fields with an array of fields as an argument.
  2. Retrieves a node from props.nodeModel.graphModel.getNodeModelById(loop_node_id).
  3. If the retrieved node is not null, it sets the configuration fields of this node to fields.
  4. After updating the node's fields, it calls loop_node.clear_next_node_field(true).

Here are some comments and optimizations to consider:

Comments:

  • The docstring describing these operations would be helpful for understanding what each part does.

Optimization/Suggestions:

  • Ensure that loop_node_properties.config.fields can handle arrays correctly. Adding fields should typically result in appending them to the existing array rather than overwriting it entirely unless there's specific logic preventing updates.
  • Consider if there might be performance implications related to how these functions are called frequently or within intensive loops.

Improved Code Example

const refresh_loop_fields = (fields: Array<any>, loop_node_id: string) => {
  const loop_node = props.nodeModel.graphModel.getNodeModelById(loop_node_Id);
  
  if (!loop_node || !Array.isArray(fields)) return;

  try {
    // Safely set new field values while maintaining existing ones
    loop_node.properties.config.fields.push(...fields);

    // Optionally remove next-node-specific fields after update
    loop_node.clear_next_node_field(true);
  } catch (e) {
    console.error('Error refreshing Loop Fields:', e);
  }
}

This version improves robustness by checking for empty/null conditions early on and includes error handling for cases where things go wrong during execution.

Expand Down
Loading