Skip to content

fix: The image uploaded from the workflow knowledge base zip file cannot be parsed #4509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 12, 2025
Merged

fix: The image uploaded from the workflow knowledge base zip file cannot be parsed #4509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/common/handle/impl/text/text_split_handle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,19 @@
re.compile("(?<=\\n)(?<!#)###### (?!#).*|(?<=^)(?<!#)###### (?!#).*")
]

end = [".mp4", ".avi", ".mov", ".mkv", ".flv", ".wmv", ".webm", ".mpeg", ".mpg", ".3gp", ".ts", ".rmvb",
".mp3", ".wav", ".flac", ".aac", ".ogg", ".m4a", ".wma", ".opus", ".alac", ".aiff", ".amr",
".jpg", ".jpeg", ".png", ".gif", ".bmp", ".tiff", ".webp", ".heif", ".raw", ".ico", ".svg", ".pdf"]


class TextSplitHandle(BaseSplitHandle):
def support(self, file, get_buffer):
file_name: str = file.name.lower()
if file_name.endswith(".md") or file_name.endswith('.txt') or file_name.endswith('.TXT') or file_name.endswith(
'.MD'):
return True
if '.' in file_name:
lower_name = file_name.lower()
if any([True for item in end if lower_name.endswith(item)]):
return False
buffer = get_buffer(file)
result = detect(buffer)
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an incorrect condition in the support method. The line if '.' in file_name: does not properly check for supported document types specified later in the class.

Here's a corrected version of the code:

#!/usr/bin/env python
from typing import List

import os

class BaseSplitHandle:
    pass

def detect(buffer: bytes):
    # Placeholder function to mimic actual detection logic, should be implemented
    raise NotImplementedError("Implement text detection")

file_extensions_support_md: List[str] = [
    ".md",  ".txt",  ".TXT",  ".MD"
]

file_extensions_support_video: List[str] = [
    ".mp4", ".avi", ".mov", ".mkv", ".flv", ".wmv", ".webm", ".mpeg", ".mpg", ".3gp", ".ts", ".rmvb",
    ".mp3", ".wav", ".flac", ".aac", ".ogg", ".m4a", ".wma", ".opus", ".alac", ".aiff", ".amr",
]

file_extensions_support_images: List[str] = [
    ".jpg", ".jpeg", ".png", ".gif", ".bmp", ".tiff", ".webp", ".heif", ".raw", ".ico", ".svg", ".pdf"
]

class TextSplitHandle(BaseSplitHandle):
    def support(self, file, get_buffer):
        original_file_extension = file.name.split(".")[-1].lower()
        
        if original_file_extension == "docx" or \
           original_file_extension == "xlsx" or \
           original_file_extension == "py":
            return False 
        
        for ext in file_extensions_support_videos:
            if original_file_extension.startswith(ext):
                return False
        
        for ext in file_extensions_support_images:
            if original_file_extension.startswith(ext):
                return False
            
        return True

Changes made:

  1. Corrected Condition: Removed the incorrect condition checking the presence of a dot (.) in file_name. Added checks for valid .md, .txt, .TXT, and .MD files using a list comprehension.

  2. Improved Logic:

    • Used original_file_extension variable to handle file extension extraction without splitting on dots.
    • Checked each video type before returning False.
    • Similarly checked each image type before returning False.

This ensures that files with recognized extensions return false, indicating they are handled separately. This approach aligns better with common practices used when handling various file types.

Expand Down
Loading