Skip to content

fix: In the workflow knowledge base, the specified reply node failed to parse the global variable input #4524 #4528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 17, 2025
+1 −1
Merged

fix: In the workflow knowledge base, the specified reply node failed to parse the global variable input #4524 #4528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/workflow/nodes/knowledge-base-node/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const nodeFields = computed(() => {
const fields = props.nodeModel.properties.user_input_field_list.map((item: any) => ({
label: typeof item.label == 'string' ? item.label : item.label.label,
value: item.field,
globeLabel: `{{global.${typeof item.label == 'string' ? item.label : item.label.label}}}`,
globeLabel: `{{global.${item.field}}}`,
globeValue: `{{context['global'].${item.field}}}`,
}))
set(props.nodeModel.properties.config, 'globalFields', fields)
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appears to be setting up fields based on user input, and there are a few points that could improve clarity or functionality:

  1. Type Checking: Use strict type checking where possible. For example:

    type Field = {
  label?: string;
  field: string;
  globeLabel?: string;
};

const nodeFields = computed(() => {
  return props.nodeModel.properties.user_input_field_list.map((item: any): Field => ({
    label: typeof item.label === 'string' ? item.label : (item.label && item.label.label),
    value: item.field,
    globeLabel: global[item.label]?.label || '',
    globeValue: context.global[item.field] || '',
  }));
});

  2. Conditional Handling for Globe Label:
    If you want to handle cases where global might not have the field (undefined, etc.), consider using optional chaining.

  3. String Interpolation: The use of mustache syntax {} can sometimes lead to confusion with other interpolation methods if used within template literals. Avoid mixing different formatting styles unless necessary.

  4. Set Function: Ensure this is being called properly and correctly applies changes.

By implementing these improvements, the code becomes more robust, easier to understand, and less prone to runtime errors related to missing properties.

Expand Down
Loading