Skip to content

chore(deps): update 2fauth/2fauth docker tag to v5.4.1 #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
Nov 18, 2024
Merged

chore(deps): update 2fauth/2fauth docker tag to v5.4.1 #2536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a1347
chore(deps): update 2fauth/2fauth docker tag to v5.4.1
renovate[bot] Nov 18, 2024
714cd2e
Update app version [skip ci]
Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 apps/2fauth/5.4.0/data.yml → apps/2fauth/5.4.1/data.yml
View file
Open in desktop
File renamed without changes.
0 apps/2fauth/5.4.0/data/.gitkeep → apps/2fauth/5.4.1/data/.gitkeep
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/2fauth/5.4.0/docker-compose.yml → apps/2fauth/5.4.1/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
2fauth:
image: 2fauth/2fauth:5.4.0
image: 2fauth/2fauth:5.4.1
container_name: ${CONTAINER_NAME}
restart: always
ports:
Copy link

@fit2cloudrd fit2cloudrd Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码存在几个问题。

第一，在 "services:" 部分应写为 'services:'。
第二，使用 ${CONTAINER_NAME} 是不正确的操作。在实际部署容器时需要确保正确指定 Docker 容器名称，并且不能硬编码到配置中作为变量名。应当以一种更可靠、结构化的模式来命名和定义 dockerfile 进程（如将 CONTAINER_NAME 替换为具体的业务 ID）。例如：

services:
  - name: my_container_service

在这个例子中，我们创建了一个服务项并为其分配了唯一的 "name" 值 "my_container_service"。这个值可以是任何有意义的标识符，用于识别具体的服务项目。对于具体的容器实例而言，可能还需要进行一些配置修改来适应实际情况。

第三，docker-compose.yml 的版本号应该是数字类型并且有逗号隔开（而不是字符串），这样可以方便地与不同的 Docker Compose 版本保持一致性。如果此文件包含多个版本，则应该添加一个或多个空行来避免混淆，并将其视为多个独立的 docker-compose 文件。以下是一个改进之后的例子：

version: "3"
services:

  - service-name

extends:
# 更多扩展配置在这里可嵌入多个伸缩声明

上述内容仅供参考，具体实现还需根据您当前项目的具体情况调整。

Expand Down
0 apps/2fauth/5.4.0/scripts/init.sh → apps/2fauth/5.4.1/scripts/init.sh
View file
Open in desktop
File renamed without changes.