Skip to content

chore(deps): update advplyr/audiobookshelf docker tag to v2.17.0 #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
Nov 18, 2024
Merged

chore(deps): update advplyr/audiobookshelf docker tag to v2.17.0 #2537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74d1968
chore(deps): update advplyr/audiobookshelf docker tag to v2.17.0
renovate[bot] Nov 18, 2024
792526a
Update app version [skip ci]
Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 apps/audiobookshelf/2.16.2/data.yml → apps/audiobookshelf/2.17.0/data.yml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .../audiobookshelf/2.16.2/docker-compose.yml → .../audiobookshelf/2.17.0/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ services:
- "./data/podcasts:/podcasts"
- "./data/config:/config"
- "./data/metadata:/metadata"
image: advplyr/audiobookshelf:2.16.2
image: advplyr/audiobookshelf:2.17.0
labels:
createdBy: "Apps"

Copy link

@fit2cloudrd fit2cloudrd Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在检查代码时，可以观察到以下几点问题：

  1. 段落中的逗号与括号混用：此段落应包含两个标点符号。

  2. 转义字符：" / ": 在字符串前有多个转义字符会导致拼写错误。

  3. 命名空间命名风格不统一。应该使用标准库函数或类名称，并保持一致性，例如使用 Python 中的方法 split() 而不是 PHP 的。

根据这些发现，我们可以提出以下几条改善建议：

  1. 请确保所有使用的引号和括号前后都正确嵌套及关闭。

  2. 尝试更正上述提到的缩进（如使用Python中正确的空格）。

  3. 提倡并坚持一致的标准命名方式（即按照PEP-8推荐），这样代码阅读性和可维护性会更高。

Expand Down