Skip to content

chore(deps): update 2fauth/2fauth docker tag to v5.4.2 #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
Nov 20, 2024
Merged

chore(deps): update 2fauth/2fauth docker tag to v5.4.2 #2542

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e68a80
chore(deps): update 2fauth/2fauth docker tag to v5.4.2
renovate[bot] Nov 18, 2024
ea227f0
Update app version [skip ci]
Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/2fauth/5.4.1/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
2fauth:
image: 2fauth/2fauth:5.4.1
image: 2fauth/2fauth:5.4.2
container_name: ${CONTAINER_NAME}
restart: always
ports:
Copy link

@fit2cloudrd fit2cloudrd Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该代码没有明显的错误或违规问题，但建议进行以下几个方面优化：

  1. 变量命名统一使用大写首字母的英文单词（如 $containerName)）；

  2. 将ports:中的内容替换为具体的端口数字和网络类型字符串，以确保可读性和准确性。

services:

  # 假设 $IMAGE 是需要使用的镜像名称
  authserver_service:
    deployer:
      type: docker-compose 
      service:
        image: $IMAGE

这样可以保持一致且简洁的语言风格：

$IMAGE = '2fauth/2fauth:5.4.2';
services:
  
  authserver_service:
    deployer:
      type: docker-compose    
      service:
        image: $IMAGE

Expand Down