Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/uuwaf/6.1.0/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ services:
command: ["/run.sh"]
environment:
- TZ=Asia/Shanghai
- UUWAF_MYSQL_PASSWORD=Safe3.WAF
links:
- wafdb
depends_on:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码中没有发现明显的问题或不规范之处,但是可能有一点点修改建议:

将环境变量UUWAF_MYSQL_PASSWORD添加到依赖项列表(depends_on:)中的顺序可能是更理想的选择,因为如果这些设置会影响到脚本运行的结果或者安全性,则应该先于其他的配置被使用。

此外,在代码结构和格式上的小变动可能会让项目看起来更加专业。因此,在保持现有代码质量的同时稍作调整以适应当前最佳实践是合适的。这样的微调对整体质量提升帮助不大但是有助于提高可读性和一致性。

Expand Down