Skip to content

chore(deps): update 1dev/server docker tag to v11.5.3 #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
Nov 21, 2024
Merged

chore(deps): update 1dev/server docker tag to v11.5.3 #2562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edaf33d
chore(deps): update 1dev/server docker tag to v11.5.3
renovate[bot] Nov 21, 2024
078bd5b
Update app version [skip ci]
Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 apps/onedev/11.5.2/data.yml → apps/onedev/11.5.3/data.yml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/onedev/11.5.2/docker-compose.yml → apps/onedev/11.5.3/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
onedev:
image: 1dev/server:11.5.2
image: 1dev/server:11.5.3
container_name: ${CONTAINER_NAME}
restart: always
networks:
Copy link

@fit2cloudrd fit2cloudrd Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该问题在当前代码中未发现明显的语法错误或缺失信息，但考虑到版本变更（从1dev/server:xxxx到server:xxxx），可能存在以下几点修改建议：

  1. 需要确保与容器镜像相关联的服务名命名规范：使用大小写字母和数字混合的方式，例如"app_服务器", "service_test", 等等。这有助于避免服务名称冲突。

  2. 在更新docker run命令时，请注意指定准确的镜像ID，并将容器名称正确设置为项目中的实际变量${CONTAINER_NAME}或其他可替代形式。

另外，在正式部署之前进行上述更改并测试是至关重要的。

Expand Down