Skip to content

chore(deps): update apache/answer docker tag to v1.4.1 #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
Nov 25, 2024
Merged

chore(deps): update apache/answer docker tag to v1.4.1 #2570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65b4abf
chore(deps): update apache/answer docker tag to v1.4.1
renovate[bot] Nov 22, 2024
e96388a
Update app version [skip ci]
Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 apps/answer/1.4.0/data.yml → apps/answer/1.4.1/data.yml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/answer/1.4.0/docker-compose.yml → apps/answer/1.4.1/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ services:
- "${PANEL_APP_PORT_HTTP}:80"
volumes:
- "./data:/data"
image: apache/answer:1.4.0
image: apache/answer:1.4.1
labels:
createdBy: "Apps"
networks:
Copy link

@fit2cloudrd fit2cloudrd Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码没有明显的错误或不规范，但可以进行一些小的修改以改进可维护性：

  1. 使用空格分隔变量名（如 @${PANEL_APP_PORT_HTTP} 而不是仅使用斜杠）：这有助于增强读取这些配置时的可读性和可测试性。
  2. 将networks:标签从一个字符串更改为字典来支持多网络设置（比如只指定其中几个服务在某些网络内的绑定）。这样可以使行为更容易扩展。

整体来说，这个脚本用于配置答案问答应用的服务相关参数和卷。如果要将此代码放入一个名为deploy.yml的文件，并将其作为docker-compose命令的一部分运行的话，则应按照以下方式调整其格式：

services:
  - name: answerapp
    ports:
      - targetPort:80
        protocol:TCP
    volumes:
      - ./data:/var/data

volumes:
  - data_path:/var/data

image: docker.io/harvestanswers/apache-answer
    
labels:
  createdBy: Apps

ports:
  - containerPort:9001


resources:
  limits:
    
  requests:

networks:
  - name: default

这是一个基本架构示例，允许你根据需要添加更多细节。

Expand Down