Skip to content

chore(deps): update homeassistant/home-assistant docker tag to v2024.11.3 #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
Nov 25, 2024
Merged

chore(deps): update homeassistant/home-assistant docker tag to v2024.11.3 #2574

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e5733c
chore(deps): update homeassistant/home-assistant docker tag to v2024.…
renovate[bot] Nov 22, 2024
1fec157
Update app version [skip ci]
Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/home-assistant/2024.11.2/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ services:
- "/run/dbus:/run/dbus:ro"
environment:
- TZ=${TIME_ZONE}
image: homeassistant/home-assistant:2024.11.2
image: homeassistant/home-assistant:2024.11.3
labels:
createdBy: "Apps"
Copy link

@fit2cloudrd fit2cloudrd Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在提供的Dockerfile中，我发现了两个问题：

  1. 不应有/run/dbus / run/dbus:ro这个服务挂载项。这是Linux下的文件系统隔离机制的一部分。

解决方案：删除此条目或将它移动到适当的位置（例如 /usr/lib/dbus, /usr/share/dbus 或其他更安全的地方），以防止其暴露于用户空间进程。

  1. Docker容器名称和标签需要明确区分是旧镜像还是新版本，但这里直接使用了"homeassistant/hassio"作为标签名以及创建者的信息，这样可能会引发混淆。
    警告：应该保持一致的命名标准并在注释中加以说明，确保所有相关的操作都基于一个清晰的标识符，如应用名称等。

所以优化后的Dockerfile应该是：

services:
  - "/tmp:/rootfs"
image: homeassistant/home-assistant:2024.11.3

labels:
  CreatedBy: AppName Here is the correct value to replace 'AppName'

请注意，您可能需要用实际的AppName替换AppName Here is the correct value to replace 'AppName'中的字符串，并根据具体情况进行相应调整。