Skip to content

chore(deps): update dpage/pgadmin4 docker tag to v9.4 #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
May 29, 2025
Merged

chore(deps): update dpage/pgadmin4 docker tag to v9.4 #4025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
834e93d
chore(deps): update dpage/pgadmin4 docker tag to v9.4
renovate[bot] May 29, 2025
f420ff0
Update app version [skip ci]
May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 apps/pgadmin4/9.3/data.yml → apps/pgadmin4/9.4/data.yml
View file
Open in desktop
File renamed without changes.
0 apps/pgadmin4/9.3/data/.gitkeep → apps/pgadmin4/9.4/data/.gitkeep
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/pgadmin4/9.3/docker-compose.yml → apps/pgadmin4/9.4/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
pgadmin4:
image: dpage/pgadmin4:9.3
image: dpage/pgadmin4:9.4
container_name: ${CONTAINER_NAME}
restart: always
labels:
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between the two lines of the services configuration block indicates that there is an upgrade from version 9.3 to 9.4 of PGAdmin. This change does not introduce any direct irregularities or potential issues; it simply reflects that you have upgraded your service to a newer version.

Suggested Optimization:

  1. Environment Variables Management: Ensure that environment variables like ${CONTAINER_NAME} are correctly defined and passed. Improving the readability of these declarations can be beneficial, especially if they represent sensitive information.

Here’s how you might enhance them for improved clarity:

@@ -1,6 +1,6 @@
 services:
   pgadmin4:
     image: dpage/pgadmin4:9.4
     container_name: ${PGADMIN_CONTAINER}  # More descriptive name
     restart: always
     labels:
       app.type: web

By using more meaningful names in the environment variable identifiers (like PGADMIN_CONTAINER), you improve maintainability and readability.

Expand Down
0 apps/pgadmin4/9.3/scripts/init.sh → apps/pgadmin4/9.4/scripts/init.sh
View file
Open in desktop
File renamed without changes.