Skip to content

chore(deps): update prom/prometheus docker tag to v3.4.1 #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
May 31, 2025
Merged

chore(deps): update prom/prometheus docker tag to v3.4.1 #4038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f28f45
chore(deps): update prom/prometheus docker tag to v3.4.1
renovate[bot] May 31, 2025
ec33a6a
Update app version [skip ci]
May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 apps/prometheus/3.4.0/conf/prometheus.yml → apps/prometheus/3.4.1/conf/prometheus.yml
View file
Open in desktop
File renamed without changes.
0 apps/prometheus/3.4.0/data.yml → apps/prometheus/3.4.1/data.yml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/prometheus/3.4.0/docker-compose.yml → apps/prometheus/3.4.1/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ services:
volumes:
- ./conf:/etc/prometheus/
- ./prometheus:/prometheus
image: prom/prometheus:v3.4.0
image: prom/prometheus:v3.4.1
command:
- '--config.file=/etc/prometheus/prometheus.yml'
- '--storage.tsdb.path=/prometheus'
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appears to be correct and optimized for updating Prometheus from version v3.4.0 to v3.4.1. Here's a brief analysis of the changes:

Changes & Observations:

  1. Image Update:
    • The Docker image used is being upgraded from prom/prometheus:v3.4.0 to prom/prometheus:v3.4.1. This ensures that you are fetching the latest stable version of Prometheus, which includes any bug fixes or features present in this release.

Potential Issues:

  • There don't appear to be any obvious logical error or inconsistencies in the code snippet provided.
  • Ensure that any customizations (e.g., configurations stored at /etc/prometheus/) remain intact when upgrading images.

Recommendations:

  1. Validation Testing: After applying these changes, run thorough validation tests on the new Prometheus setup to ensure all alerts are working correctly and there are no data ingestion bottlenecks.

  2. Monitoring: Consider setting up monitoring to log service health metrics like CPU usage, memory consumption, and disk utilization during the upgrade process to detect any performance issues early.

  3. Documentation Review: If the deployment involves multiple services, review the documentation to confirm that the new parameters (--config.file, --storage.tsdb.path) do not conflict with other configuration options set outside this block.

Summary:

The updates should work as intended given they only involve an image replacement. Verify functionality through testing before going live.

Expand Down
0 apps/prometheus/3.4.0/prometheus/.gitkeep → apps/prometheus/3.4.1/prometheus/.gitkeep
View file
Open in desktop
File renamed without changes.
0 apps/prometheus/3.4.0/scripts/init.sh → apps/prometheus/3.4.1/scripts/init.sh
View file
Open in desktop
File renamed without changes.