Switch to /usr/bin/env bash in entrypoint.sh#81
Closed
Srylax wants to merge 1 commit into1Password:mainfrom
Closed
Switch to /usr/bin/env bash in entrypoint.sh#81Srylax wants to merge 1 commit into1Password:mainfrom
Srylax wants to merge 1 commit into1Password:mainfrom
Conversation
|
What is the status of this pull request? If it is already rejected, then please close it. It is confusing :(. |
Contributor
|
Closing as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using hardcoded paths (
/bin/bash) is generally a bad practice.Please use the POSIX compliant
/usr/bin/env bashinstead.Self-hosted runners that use a system like NixOS will currently fail to use the 1Password Action.