Merged
Conversation
…ith parameters of created item. example.py reads vault id from env var. Call to run example.py added to pipeline
…or. Edited GitHub Secret names to match.
hculea
reviewed
Feb 3, 2025
hculea
reviewed
Feb 3, 2025
hculea
reviewed
Feb 3, 2025
hculea
reviewed
Feb 3, 2025
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
df40bab to
337ab76
Compare
337ab76 to
03e4e6e
Compare
…r read from environment variables
MOmarMiraj
reviewed
Mar 6, 2025
MOmarMiraj
reviewed
Mar 6, 2025
MOmarMiraj
reviewed
Apr 11, 2025
MOmarMiraj
approved these changes
Apr 11, 2025
Contributor
MOmarMiraj
left a comment
There was a problem hiding this comment.
Fixed up with Morgan and LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Altered logic in
example/example.pyto read the previously hardcodedvault_idfrom environment variables.Added
example/example.pyto the validation workflow, and readOP_SERVICE_ACCOUNT_TOKENandOP_VAULT_IDfrom GitHub secrets.Altered the example
client.secrets.resolveto resolve field from item created during theexample.pyitem CRUD.