Skip to content

Conversation

@nixel2007
Copy link
Member

Описание

Связанные задачи

Closes

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

Copilot AI and others added 5 commits December 17, 2025 14:15
* Add Parameter semantic token type for parameter usages

- Modified addVariableSymbols to use SemanticTokenTypes.Parameter for variables with VariableKind.PARAMETER
- Handle parameter and variable references from ReferenceIndex

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: nixel2007 <[email protected]>
Co-authored-by: Nikita Fedkin <[email protected]>
Co-authored-by: Copilot <[email protected]>
Update utils dependency version to 0.6.7
Update io.github.1c-syntax utils version to 0.6.8
Copilot AI review requested due to automatic review settings December 18, 2025 12:05
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nixel2007 nixel2007 merged commit 5b740cf into master Dec 18, 2025
37 of 40 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request (version 0.25.1) enhances semantic token handling for parameters and variables in the BSL Language Server. The primary goal is to properly differentiate between parameters and variables in semantic highlighting, ensuring that parameters are consistently highlighted with the Parameter token type while variables use the Variable token type.

Key Changes

  • Enhanced semantic token provider to distinguish between parameters and variables using VariableKind
  • Refactored test infrastructure from mocked ReferenceIndex to using ReferenceIndexFiller for more realistic testing
  • Added comprehensive test coverage for parameter and variable token types and their usages
  • Updated dependency from utils 0.6.6 to 0.6.8

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
build.gradle.kts Updates utils dependency from 0.6.6 to 0.6.8
SemanticTokensProvider.java Adds logic to skip parameters in variable processing and handle parameter/variable references separately based on VariableKind; adds definition modifier to parameter declarations
SemanticTokensProviderTest.java Replaces mocking approach with ReferenceIndexFiller, updates test setup, adds new comprehensive tests for parameter and variable token handling
SemanticTokensProviderParameterTest.bsl New test resource file with Russian BSL code testing parameter and variable usage scenarios

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants