-
Notifications
You must be signed in to change notification settings - Fork 121
0.25.1 #3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add Parameter semantic token type for parameter usages - Modified addVariableSymbols to use SemanticTokenTypes.Parameter for variables with VariableKind.PARAMETER - Handle parameter and variable references from ReferenceIndex --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: nixel2007 <[email protected]> Co-authored-by: Nikita Fedkin <[email protected]> Co-authored-by: Copilot <[email protected]>
Update utils dependency version to 0.6.7
Update io.github.1c-syntax utils version to 0.6.8
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request (version 0.25.1) enhances semantic token handling for parameters and variables in the BSL Language Server. The primary goal is to properly differentiate between parameters and variables in semantic highlighting, ensuring that parameters are consistently highlighted with the Parameter token type while variables use the Variable token type.
Key Changes
- Enhanced semantic token provider to distinguish between parameters and variables using
VariableKind - Refactored test infrastructure from mocked
ReferenceIndexto usingReferenceIndexFillerfor more realistic testing - Added comprehensive test coverage for parameter and variable token types and their usages
- Updated dependency from
utils0.6.6 to 0.6.8
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
build.gradle.kts |
Updates utils dependency from 0.6.6 to 0.6.8 |
SemanticTokensProvider.java |
Adds logic to skip parameters in variable processing and handle parameter/variable references separately based on VariableKind; adds definition modifier to parameter declarations |
SemanticTokensProviderTest.java |
Replaces mocking approach with ReferenceIndexFiller, updates test setup, adds new comprehensive tests for parameter and variable token handling |
SemanticTokensProviderParameterTest.bsl |
New test resource file with Russian BSL code testing parameter and variable usage scenarios |
|



Описание
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно