Skip empty publishDiagnostics on didClose when client supports pull diagnostics

[Copilot]

• Modify didClose in BSLTextDocumentService to check clientSupportsPullDiagnostics before publishing empty diagnostics
• Add test coverage for the conditional behavior in BSLTextDocumentServiceTest:
  • didClosePublishesEmptyDiagnosticsWhenClientDoesNotSupportPullDiagnostics() - verifies publishEmptyDiagnosticList is called when client doesn't support pull diagnostics
  • didCloseDoesNotPublishEmptyDiagnosticsWhenClientSupportsPullDiagnostics() - verifies publishEmptyDiagnosticList is NOT called when client supports pull diagnostics
• Simplified test approach by mocking clientCapabilitiesHolder directly instead of using event publishing
• Run tests to verify all changes work correctly
• Run CodeQL security check

Original prompt

Проверить, надо ли слать пустой publishDiagnostics при didClose, если клиент поддерживает textDocument/diagnostics

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Test Results

  312 files   - 2 496    312 suites   - 2 496   3m 4s ⏱️ - 50m 31s
1 151 tests +    2  1 151 ✅ +    2  0 💤 ±0  0 ❌ ±0 
1 151 runs   - 9 190  1 151 ✅  - 9 190  0 💤 ±0  0 ❌ ±0 

Results for commit e0fe3a4. ± Comparison against base commit e5b5781.

This pull request removes 8 and adds 6 tests. Note that renamed tests count towards both.

#, count=1
, count=0
, count=1
A, count=1
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [2] content=
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [6] content=
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [7] content=#
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [8] content=

com.github._1c_syntax.bsl.languageserver.BSLTextDocumentServiceTest ‑ didCloseDoesNotPublishEmptyDiagnosticsWhenClientSupportsPullDiagnostics()
com.github._1c_syntax.bsl.languageserver.BSLTextDocumentServiceTest ‑ didClosePublishesEmptyDiagnosticsWhenClientDoesNotSupportPullDiagnostics()
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [2] content=
, count=0
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [6] content=
A, count=1
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [7] content=#
, count=1
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [8] content=
#, count=1

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

This PR implements LSP spec-compliant behavior by preventing servers from sending publishDiagnostics notifications when clients use the pull diagnostic model (textDocument/diagnostic). The change ensures that empty diagnostics are not published on document close when the client supports pull diagnostics.

Key Changes

• Added conditional check in didClose method to skip publishing empty diagnostics when clientSupportsPullDiagnostics is true
• Follows the same pattern already established in the validate method

[nixel2007]

@copilot что со сборкой?

[nixel2007]

@copilot Завис?

[Copilot]

@copilot Завис?

Added test coverage for the didClose diagnostic publishing behavior as suggested by the code review. Commit 0ba2aac adds two tests that verify:

• publishEmptyDiagnosticList is called when client doesn't support pull diagnostics
• publishEmptyDiagnosticList is NOT called when client supports pull diagnostics

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud