Исправлен дедлок при построении контекста, если при открытии проекта открыт документ

[nixel2007]

Описание

Связанные задачи

Closes

Чеклист

Общие

• Ветка PR обновлена из develop
• Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
• Изменения покрыты тестами
• Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

• Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

Summary by CodeRabbit

• Refactor
  • Enhanced document retrieval performance through optimized access patterns in reference indexing operations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

A new unsynchronized document retrieval method getDocumentNoLock() is added to ServerContext for performance-critical scenarios where external synchronization is guaranteed. ReferenceIndex is updated to use this new method instead of the synchronized getDocument() call.

Changes

Cohort / File(s)	Summary
Unsynchronized document access src/main/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContext.java	Added public method getDocumentNoLock(URI uri) that bypasses locking mechanism and directly accesses the internal documents map. Method is annotated @Nullable with documentation restricting usage to scenarios with guaranteed external synchronization or when eventual consistency is acceptable.
ReferenceIndex lock optimization src/main/java/com/github/_1c_syntax/bsl/languageserver/references/ReferenceIndex.java	Updated getFromSymbol() to call getDocumentNoLock(uri) instead of getDocument(uri), replacing the synchronized retrieval with unsynchronized access. Remaining fluent chain (symbolTree mapping and error handling) remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• Исправлена гонка на заполнении контекста и LSP операциях #3729: Introduces per-URI locking and modifies ServerContext.getDocument/getDocumentLock methods, directly related to the new getDocumentNoLock addition and document access strategy.

Poem

🐰 A rabbit speeds through locks unbounded,
No waiting queues, no threads compounded,
When safe to peek, performance grows,
Swift as the warren's fastest does! 🌙✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: fixing a deadlock during context initialization when a document is open at project startup. This matches the code changes which introduce a lock-free document retrieval method to address concurrency issues.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nixel2007]

/buildJar

[github-actions]

✅ Собраны JAR-файлы для этого PR по команде /buildJar.

Артефакт: 5151422564

Файлы внутри:

• bsl-language-server-fix-startup-deadlock-7bde9bc-exec.jar

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

 2 907 files  ±0   2 907 suites  ±0   1h 1m 59s ⏱️ - 3m 28s
 1 227 tests ±0   1 227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
11 043 runs  ±0  11 043 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7bde9bc. ± Comparison against base commit 7e5f646.