Fix false positive metadata diagnostics on support-locked objects#3808
Draft
Fix false positive metadata diagnostics on support-locked objects#3808
Conversation
…jects Add skipSupportMode() to DiagnosticInfo to expose the configured SkipSupport setting. Add needToAnalyzeMdo() filter in AbstractMetadataDiagnostic.checkMetadataWithoutModules() to skip metadata objects whose SupportVariant should be excluded per the skipSupport configuration. Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix false positive in metadata naming diagnosis
Fix false positive metadata diagnostics on support-locked objects
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForbiddenMetadataName(and all otherAbstractMetadataDiagnosticsubclasses) fires on metadata objects "on support locked" even whenskipSupport=withSupportLockedis configured. The root cause:DiagnosticsConfiguration.checkSupport()only checks the document-level support variant (the SessionModule), butcheckMetadataWithoutModules()iterates all MDOs fromServerContextwithout checking each object's individualSupportVariant.Changes
DiagnosticInfo— exposeskipSupportMode()so diagnostics can read the configuredSkipSupportvia the existinginfofieldAbstractMetadataDiagnostic— addneedToAnalyzeMdo(MD)filter incheckMetadataWithoutModules()that checks each MDO'sSupportVariantagainst the skip mode:ForbiddenMetadataName,MetadataObjectNameLength,SameMetadataObjectAndChildNames,DenyIncompleteValues,ScheduledJobHandler) benefit automatically — no subclass changes needed.ForbiddenMetadataNameDiagnosticTest— addedtestSkipSupportLockedMdoInSessionModuleverifying zero diagnostics when all MDOs areNOT_EDITABLEwithWITH_SUPPORT_LOCKEDconfigOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.