Conversation
Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
- Extract version once and reuse in both release and develop steps - Use the gradle-extracted version (without 'v' prefix) instead of github.event.release.tag_name - Push the actual version tag first, then create and push latest/develop tags - This fixes the error where docker tried to tag 'v0.28.3' which didn't exist Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
…-workflow Fix Docker image tag mismatch in publish workflow
Revert HEAD_BRANCH env variable in qa.yml checkout action
Bumps [io.sentry.jvm.gradle](https://github.com/getsentry/sentry-android-gradle-plugin) from 6.0.0-rc.1 to 6.0.0. - [Release notes](https://github.com/getsentry/sentry-android-gradle-plugin/releases) - [Changelog](https://github.com/getsentry/sentry-android-gradle-plugin/blob/main/CHANGELOG.md) - [Commits](getsentry/sentry-android-gradle-plugin@6.0.0-rc.1...6.0.0) --- updated-dependencies: - dependency-name: io.sentry.jvm.gradle dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps gradle-wrapper from 9.2.1 to 9.3.0. --- updated-dependencies: - dependency-name: gradle-wrapper dependency-version: 9.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…vm.gradle-6.0.0 Bump io.sentry.jvm.gradle from 6.0.0-rc.1 to 6.0.0
…per-9.3.0 Bump gradle-wrapper from 9.2.1 to 9.3.0
Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
…tion-queries-context Fix NullPointerException in QueryPackageFoldingRangeSupplier for incomplete queries
Bumps gradle-wrapper from 9.3.0 to 9.3.1. --- updated-dependencies: - dependency-name: gradle-wrapper dependency-version: 9.3.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…per-9.3.1 Bump gradle-wrapper from 9.3.0 to 9.3.1
Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 12 to 14. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v12...v14) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-version: '14' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…idd6/action-download-artifact-14 Bump dawidd6/action-download-artifact from 12 to 14
Bumps com.gorylenko.gradle-git-properties from 2.5.4 to 2.5.5. --- updated-dependencies: - dependency-name: com.gorylenko.gradle-git-properties dependency-version: 2.5.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ko.gradle-git-properties-2.5.5 Bump com.gorylenko.gradle-git-properties from 2.5.4 to 2.5.5
When editing a token on the same line (lineOffset==0), the boundary token's deltaStart was incorrectly included in the suffix match. This caused the client to keep the old deltaStart value, shifting all subsequent tokens on the line to wrong positions. The fix excludes the boundary token from suffix match when its deltaStart differs, consistent with how boundary tokens with offset deltaLine are already handled for lineOffset!=0 case. Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
…oken Fix semantic token highlighting shift on inline token edits
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR looks like a release-prep (“0.28.4”) update that bundles a semantic-tokens delta fix, a folding-range NPE guard for incomplete SDBL query packages, and several build/CI tooling bumps.
Changes:
- Fix semantic tokens delta suffix matching so boundary tokens with changed
deltaStartare not incorrectly treated as unchanged. - Make query-package folding range generation resilient to incomplete/malformed query AST nodes (null start/stop tokens), plus add a regression test fixture.
- Update Gradle wrapper / Gradle plugins and adjust GitHub Actions workflows (QA and Docker publish).
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/.../providers/SemanticTokensProvider.java |
Adjustes suffix-match logic to exclude inline boundary tokens with changed deltaStart. |
src/test/java/.../providers/SemanticTokensProviderTest.java |
Updates an existing delta test expectation and adds a new regression test for inline token modification. |
src/main/java/.../folding/QueryPackageFoldingRangeSupplier.java |
Returns null folding range when start/stop tokens are missing; filters nulls out. |
src/test/java/.../folding/QueryPackageFoldingRangeSupplierTest.java |
Adds a test case for incomplete query packages. |
src/test/resources/folding/QueryPackageFoldingRangeSupplierIncomplete.bsl |
New fixture to reproduce incomplete-query folding scenario. |
build.gradle.kts |
Updates Sentry Gradle plugin version and git-properties plugin version. |
.github/workflows/qa.yml |
Updates artifact download action version; ref handling tweak for checkout. |
.github/workflows/publish-to-docker-hub.yml |
Adds a step to extract Gradle project version and uses it for tagging/pushing. |
gradle/wrapper/gradle-wrapper.properties |
Bumps Gradle wrapper distribution URL version. |
gradle/wrapper/gradle-wrapper.jar |
Updates the Gradle wrapper JAR accordingly. |
| // then - should not throw NullPointerException and return available folding ranges | ||
| assertThatFoldingRanges(foldingRanges).isNotNull(); |
There was a problem hiding this comment.
The new test doesn’t really validate the behavior for an incomplete query: assertThatFoldingRanges(foldingRanges).isNotNull() will always pass as long as the method returns a (possibly empty) list, and it doesn’t assert that any folding ranges are produced from the remaining valid parts. Consider asserting expected size/ranges (or at least that the result is non-empty / matches known ranges for this fixture) to prevent regressions where folding ranges silently disappear.
| - name: Tag and push Docker image (release) | ||
| if: github.event_name == 'release' | ||
| run: | | ||
| docker push 1csyntax/bsl-language-server --all-tags | ||
| docker tag 1csyntax/bsl-language-server:${{ github.event.release.tag_name }} 1csyntax/bsl-language-server:latest | ||
| VERSION="${{ steps.version.outputs.VERSION }}" | ||
| echo "Pushing image with version tag: ${VERSION}" | ||
| docker push 1csyntax/bsl-language-server:${VERSION} | ||
| docker tag 1csyntax/bsl-language-server:${VERSION} 1csyntax/bsl-language-server:latest | ||
| docker push 1csyntax/bsl-language-server:latest |
There was a problem hiding this comment.
bootBuildImage is configured to build/tag the image as docker.io/1csyntax/bsl-language-server:${project.version} (see build.gradle.kts). Here the workflow pushes/tags 1csyntax/bsl-language-server:${VERSION} (without the docker.io/ prefix). Depending on Docker’s canonical naming, this can result in “tag does not exist” at push/tag time. Align the image name used in docker push/tag with the exact name produced by bootBuildImage (or adjust the Gradle imageName to match what the workflow expects).
Описание
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно