Skip to content

Исправление незаполненности плейсхолдеров для кеша #3825

Merged
nixel2007 merged 2 commits intodevelopfrom
hotfix/appPaths
Feb 18, 2026
Merged

Исправление незаполненности плейсхолдеров для кеша #3825
nixel2007 merged 2 commits intodevelopfrom
hotfix/appPaths

Conversation

@theshadowco
Copy link
Member

@theshadowco theshadowco commented Feb 18, 2026

Описание

Связанные задачи

Closes

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

Summary by CodeRabbit

  • Chores
    • Added two cache path configuration options (app.cache.fullPath and app.cache.basePath) with sensible defaults to improve cache directory management.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Added two Spring Boot application properties in BSLLSBinding.createApplication(): app.cache.fullPath set to an empty string ("") and app.cache.basePath set to ${user.home}. No API, class, or control-flow changes.

Changes

Cohort / File(s) Summary
Cache Configuration Properties
src/main/java/com/github/_1c_syntax/bsl/languageserver/BSLLSBinding.java
Inserted two application properties into the SpringApplication properties Map: app.cache.fullPath = "", and app.cache.basePath = "${user.home}". Minimal local change to configuration map.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 I hopped through config, soft and spry,
Two little paths beneath the sky.
One empty trail, one homeward way,
Cached crumbs to guide the day. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title in Russian describes fixing unfilled cache placeholder properties, which directly relates to the changeset adding app.cache.fullPath and app.cache.basePath configuration properties.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/appPaths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/main/java/com/github/_1c_syntax/bsl/languageserver/BSLLSBinding.java`:
- Around line 90-91: The app.cache.fullPath property in BSLLSBinding is
currently set to "${user.home}", which causes CachePathProvider.getCachePath()
to treat it as a complete override and place the cache in the user home
directory; change the configuration so fullPath is either empty (to fall back to
basePath logic that builds .bsl-language-server/cache/<hash>/) or set fullPath
to a proper subdirectory (for example "${user.home}/.bsl-language-server/cache"
or a temp-pattern like "${java.io.tmpdir}/bsl-ls-cache-${random.uuid}") so
CachePathProvider.getCachePath() will not write the cache directly into the home
root.

@github-actions
Copy link
Contributor

Test Results

 2 907 files  ±0   2 907 suites  ±0   1h 18m 52s ⏱️ + 8m 50s
 1 231 tests ±0   1 231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
11 079 runs  ±0  11 079 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6c6b348. ± Comparison against base commit acd8a3e.

@nixel2007 nixel2007 merged commit 7c4e71a into develop Feb 18, 2026
36 checks passed
@nixel2007 nixel2007 deleted the hotfix/appPaths branch February 18, 2026 16:43
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments