Merged
Conversation
ОбзорОбновлены конфигурация сборки Gradle (замена плагина лицензирования, обновление версий плагинов и зависимостей, переход на аннотации JSpecify), обновлена версия Gradle с 8.14.3 на 9.3.1, удалена обработка CLASSPATH из скриптов-оболочек, обновлены годы в копирайтах исходных файлов с 2025 на 2026. Изменения
Оцениваемая сложность кода🎯 3 (Средняя) | ⏱️ ~20 минут Стихотворение
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
src/main/java/com/github/_1c_syntax/bsl/supconf/SupportDataReader.java (1)
145-146: Форматирование LGTM; опционально — переименовать параметрdataStrings.Перенос параметров на отдельные строки улучшает читаемость. Вместе с тем, второй параметр назван
dataStrings, хотя его тип —int(числовой код варианта поддержки: 0/1/2). Это создаёт семантическую путаницу с массивомdataStrings[]в вызывающих методах.♻️ Предлагаемое переименование параметра
- private static SupportVariant computeSupportVariant(GeneralSupportVariant configurationSupportVariant, - int dataStrings) { + private static SupportVariant computeSupportVariant(GeneralSupportVariant configurationSupportVariant, + int supportVariantCode) { SupportVariant supportVariant; if (configurationSupportVariant == GeneralSupportVariant.LOCKED) { supportVariant = SupportVariant.NOT_EDITABLE; } else { - supportVariant = SupportVariant.valueOf(dataStrings); + supportVariant = SupportVariant.valueOf(supportVariantCode); } return supportVariant; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/com/github/_1c_syntax/bsl/supconf/SupportDataReader.java` around lines 145 - 146, The parameter name dataStrings in computeSupportVariant(GeneralSupportVariant configurationSupportVariant, int dataStrings) is misleading (it's an int code, not an array); rename it to a clearer name such as supportVariantCode or variantCode in the method signature and update all callers (places that currently pass the int and also that define dataStrings[] arrays) to use the new identifier, keeping logic unchanged; ensure imports/overloads/JavaDocs (if any) referencing dataStrings are updated to the new name so compilation and semantics remain correct.build.gradle.kts (3)
55-55: Доступна более новая версия commons-io.На GitHub Apache Commons IO актуальная версия уже
2.22.0, тогда как здесь используется 2.21.0. Не критично, но при возможности стоит обновить до актуальной.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@build.gradle.kts` at line 55, Update the commons-io dependency to the newer release by replacing the existing implementation("commons-io:commons-io:2.21.0") entry with the current version (e.g., 2.22.0); after changing the version, refresh/resolve Gradle dependencies (IDE sync or gradle --refresh-dependencies) and run the build to verify there are no compatibility regressions.
52-52: Использование альфа-версии SLF4J в production-зависимости.
slf4j-api:2.1.0-alpha1— это pre-release версия. Для библиотеки, публикуемой на Maven Central (java-library+maven-publish), использование альфа-зависимости вimplementationscope транзитивно повлияет на всех потребителей. Рассмотрите возможность перехода на стабильный релиз SLF4J 2.x (например,2.0.16), если он совместим.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@build.gradle.kts` at line 52, Replace the pre-release SLF4J dependency declaration implementation("org.slf4j:slf4j-api:2.1.0-alpha1") with a stable 2.x release (e.g. 2.0.16) in build.gradle.kts so consumers of your java-library/maven-publish artifact don't inherit an alpha dependency; update the version string, run a full build and tests to confirm compatibility, and if any APIs changed adjust call sites accordingly (search for slf4j usages and the implementation(...) entry to locate the change).
13-13: Закомментированный плагин.Закомментированный
io.freefair.maven-central.validate-poms— лучше удалить полностью или оставить комментарий о причине отключения (TODO/FIXME), чтобы не засорять конфигурацию.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@build.gradle.kts` at line 13, В файле обнаружена закомментированная строка плагина "// id("io.freefair.maven-central.validate-poms") version "9.2.0"" — удалите полностью этот закомментированный плагин или явно оставьте поясняющий комментарий (TODO/FIXME) с причиной отключения; найдите упоминание io.freefair.maven-central.validate-poms и либо удалите строку, либо замените её на короткий комментарий с объяснением состояния.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@build.gradle.kts`:
- Line 8: The plugin identifier declared as id("cloud.rio.license") is incorrect
and causes build failures; update the plugin declaration to use the correct
identifier id("cloud.rio.license-report") with the same version "0.18.0" in the
build.gradle.kts plugin block (locate the id(...) call that currently references
cloud.rio.license and replace it with cloud.rio.license-report).
---
Nitpick comments:
In `@build.gradle.kts`:
- Line 55: Update the commons-io dependency to the newer release by replacing
the existing implementation("commons-io:commons-io:2.21.0") entry with the
current version (e.g., 2.22.0); after changing the version, refresh/resolve
Gradle dependencies (IDE sync or gradle --refresh-dependencies) and run the
build to verify there are no compatibility regressions.
- Line 52: Replace the pre-release SLF4J dependency declaration
implementation("org.slf4j:slf4j-api:2.1.0-alpha1") with a stable 2.x release
(e.g. 2.0.16) in build.gradle.kts so consumers of your
java-library/maven-publish artifact don't inherit an alpha dependency; update
the version string, run a full build and tests to confirm compatibility, and if
any APIs changed adjust call sites accordingly (search for slf4j usages and the
implementation(...) entry to locate the change).
- Line 13: В файле обнаружена закомментированная строка плагина "//
id("io.freefair.maven-central.validate-poms") version "9.2.0"" — удалите
полностью этот закомментированный плагин или явно оставьте поясняющий
комментарий (TODO/FIXME) с причиной отключения; найдите упоминание
io.freefair.maven-central.validate-poms и либо удалите строку, либо замените её
на короткий комментарий с объяснением состояния.
In `@src/main/java/com/github/_1c_syntax/bsl/supconf/SupportDataReader.java`:
- Around line 145-146: The parameter name dataStrings in
computeSupportVariant(GeneralSupportVariant configurationSupportVariant, int
dataStrings) is misleading (it's an int code, not an array); rename it to a
clearer name such as supportVariantCode or variantCode in the method signature
and update all callers (places that currently pass the int and also that define
dataStrings[] arrays) to use the new identifier, keeping logic unchanged; ensure
imports/overloads/JavaDocs (if any) referencing dataStrings are updated to the
new name so compilation and semantics remain correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes:
Чеклист
Общие
gradlew precommit)Дополнительно