Skip to content

Configure DNS resolver#287

Merged
rustaceanrob merged 1 commit intomasterfrom
dns-2-7
Feb 12, 2025
Merged

Configure DNS resolver#287
rustaceanrob merged 1 commit intomasterfrom
dns-2-7

Conversation

@rustaceanrob
Copy link
Collaborator

If you think CloudFlare is spyware, you might want to change the DNS resolver from 1.1.1.1

cc @nyonson

Copy link
Collaborator

@nyonson nyonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7f54f30

@rustaceanrob
Copy link
Collaborator Author

Might have over-engineered my way out of the MSRV thing. Any type that is part of the node configuration must implement Default. It would've been nice to use the const constructor, but another approach is to make a new type that implements the Default socket address for the DNS resolver. Users don't need to know about this type and can just pass a SocketAddr, but internally I use this new wrapper type.

@rustaceanrob
Copy link
Collaborator Author

rustaceanrob commented Feb 12, 2025

Final tweak, port 53 is required by the spec, so it can just be implied when configured.

@rustaceanrob rustaceanrob merged commit 8588efe into master Feb 12, 2025
14 checks passed
@rustaceanrob rustaceanrob deleted the dns-2-7 branch February 12, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants